feat(platform): hide subscription banners for non-admin users

[ffirg]

Summary

Hide the "out of compliance" banner for non-admin users.

Non-admin users cannot act on subscription compliance issues, so displaying the banner to them:

• Causes confusion ("should I stop using the platform?")
• Creates unnecessary support burden

This change hides all subscription-related banners (compliance, grace period, expiry warnings) for non-superuser accounts.

Note: This replaces PR #3145 (from fork) to enable SonarQube checks which require repository secrets.

Risk Analysis - REQUIRED

• High
• Medium
• Low

Justification:

• Change is isolated to banner visibility logic only
• No API changes, no backend changes
• Uses existing usePlatformActiveUser hook (already in use elsewhere)
• All existing tests pass; 3 new tests added
• Easy to revert if needed

Changes Made

• platform/main/PlatformApp.tsx: Add is_superuser check to subscriptionBanner useMemo
• platform/main/PlatformApp.test.tsx: Add 3 new test cases covering admin/non-admin scenarios

Implementation Details

Uses existing pattern from SubscriptionDetails.tsx:

const { activePlatformUser } = usePlatformActiveUser();
// ...
if (!activePlatformUser?.is_superuser) return null;

Test Plan

• All 14 existing tests pass
• New tests verify:
  • Non-admin users do NOT see compliance banners
  • Admin users DO see compliance banners
  • Non-admin users do NOT see subscription expiry banners
• TypeScript compilation passes
• ESLint passes

Manual Testing Steps

1. Log in as a non-superuser account
2. Ensure subscription is out of compliance (or will expire soon)
3. Verify: No red/yellow subscription banner appears
4. Log in as superuser account
5. Verify: Subscription banner appears as expected

---

🤖 Generated with Claude Code

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[marshmalien]

/run-playwright

[aap-pde-ci-bot]

Currents dashboard