NOISSUE Remove request body from GET requests#17
Merged
Conversation
61c5ecd to
273345f
Compare
Wiktor6
approved these changes
May 20, 2026
lukasz-falda
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production issue
Daily pickup point import in tamago started failing today:
InPost backend (behind Cloudflare) now rejects
GET /v1/pointswhen the request carries a body:Content-Type: application/json→ HTTP 400 "Your client has issued a malformed or illegal request"Content-Type→ HTTP 502 from CloudflareReproduced from the cron pod by replaying the exact Guzzle request:
The same URL without body returns 200. Bisection confirmed body in GET is the sole trigger - all individual headers (UA, Content-Type, etc.) are fine on their own.
Fix
FindPoints::findPointswas serializing the wholeFindPointsRequestinto the body of a GET request, duplicating data already passed via query string. RFC 9110 says clients SHOULD NOT send a body in GET; InPost / Cloudflare just started enforcing it.Content-Typeheader from theHttpRequestinFindPoints.SerializerfromFindPoints::__construct(no longer needed).Test
Added
findPointsSendsGetRequestWithoutBodyregression test asserting the outgoing request is GET, has empty body and noContent-Typeheader.