NOISSUE Remove request body from GET requests

phpstan.neon

@@ -11,10 +11,6 @@ parameters:
         - %rootDir%/../../../src
 
     ignoreErrors:
-        -
-            message: '#.*NodeDefinition::children.*#'
-            path: ./src/DependencyInjection
-
         -
             message: '#.*Extension::processConfiguration.*#'
             path: ./src/DependencyInjection

src/Command/FindPoints.php

@@ -5,7 +5,6 @@
 namespace Answear\InpostBundle\Command;
 
 use Answear\InpostBundle\Client\Client;
-use Answear\InpostBundle\Client\Serializer;
 use Answear\InpostBundle\Request\FindPointsRequest;
 use Answear\InpostBundle\Response\FindPointsResponse;
 use GuzzleHttp\Psr7\Request as HttpRequest;
@@ -14,14 +13,11 @@
 class FindPoints extends AbstractCommand
 {
     private Client $client;
-    private Serializer $serializer;
 
     public function __construct(
         Client $client,
-        Serializer $serializer,
     ) {
         $this->client = $client;
-        $this->serializer = $serializer;
     }
 
     public function findPoints(FindPointsRequest $request): FindPointsResponse
@@ -30,9 +26,8 @@ public function findPoints(FindPointsRequest $request): FindPointsResponse
             $request->getMethod(),
             new Uri($request->getRequestUrl()),
             [
-                'Content-type' => 'application/json',
+                'Content-Type' => 'application/json',
             ],
-            $this->serializer->serialize($request)
         );
 
         $response = $this->client->request($httpRequest);

src/DependencyInjection/Configuration.php

@@ -15,8 +15,8 @@ public function getConfigTreeBuilder(): TreeBuilder
 
         $treeBuilder->getRootNode()
             ->children()
-            ?->scalarNode('baseUrl')->defaultNull()->end()
-            ?->end();
+                ->scalarNode('baseUrl')->defaultNull()->end()
+            ->end();
 
         return $treeBuilder;
     }

tests/Integration/Command/FindPointsTest.php

@@ -5,7 +5,6 @@
 namespace Answear\InpostBundle\Tests\Integration\Command;
 
 use Answear\InpostBundle\Client\Client;
-use Answear\InpostBundle\Client\Serializer;
 use Answear\InpostBundle\Command\FindPoints;
 use Answear\InpostBundle\ConfigProvider;
 use Answear\InpostBundle\Enum\PointFunctionsType;
@@ -89,6 +88,22 @@ public function successfulFindPointsPoland(): void
         $this->assertTrue($point->location247);
     }
 
+    /**
+     * @test
+     */
+    public function findPointsSendsGetRequestWithoutBody(): void
+    {
+        $this->mockGuzzleResponse(new Response(200, [], $this->getSuccessfulBody(self::POLAND)));
+
+        $this->getCommand()->findPoints(new FindPointsRequest());
+
+        $this->assertCount(1, $this->clientHistory);
+        $request = $this->clientHistory[0]['request'];
+        $this->assertSame('GET', $request->getMethod());
+        $this->assertSame('', (string) $request->getBody());
+        $this->assertSame(['application/json'], $request->getHeader('Content-Type'));
+    }
+
     /**
      * @test
      */
@@ -168,7 +183,7 @@ public function successfulFindPointsItaly(): void
 
     private function getCommand(): FindPoints
     {
-        return new FindPoints($this->client, new Serializer());
+        return new FindPoints($this->client);
     }
 
     private function getSuccessfulBody(string $country): string