Conversation
| for idx in indices: | ||
| if "2" in lines[idx + index_offset]: | ||
| layer_names.append(lines[idx + index_offset + 1].replace("\n", "")) | ||
| if not layer_names: |
Contributor
There was a problem hiding this comment.
Please, add some tests to cover the new lines you implemented
SMoraisAnsys
requested changes
Feb 23, 2026
Collaborator
SMoraisAnsys
left a comment
SMoraisAnsys
left a comment
There was a problem hiding this comment.
Thanks for the contribution @gkorompi Can you have a look into my comments ?
Comment on lines
+825
to
+828
| index_offset = 1 | ||
| for idx in indices: | ||
| if "2" in lines[idx + index_offset]: | ||
| layer_names.append(lines[idx + index_offset + 1].replace("\n", "")) |
Collaborator
There was a problem hiding this comment.
Could you explain the logic behind this code ?
| self.logger.warning("aedb_exists. Renaming it to %s", project_name) | ||
| if xml_path is None: | ||
| xml_path = Path("").name | ||
| xml_path = str(Path(cad_path).with_suffix(".xml")) |
Collaborator
There was a problem hiding this comment.
Why are you casting into str when the previous code was using Path ? That's also the case for the elif a line below
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
Member
|
Hi @gkorompi what is the status of this PR? I will move it to draft until you fix the suggestions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 different customers face issues with these functions.