-
Notifications
You must be signed in to change notification settings - Fork 233
FIX: dxf fixes on mcad & ecad #7298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
c5315a7
0237d65
97a8ee4
f5d31a3
82a7c28
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Dxf fixes on mcad & ecad |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -821,6 +821,11 @@ def find_indices(list_to_check, item_to_find): | |
| for idx in indices: | ||
| if "2" in lines[idx + index_offset]: | ||
| layer_names.append(lines[idx + index_offset + 1].replace("\n", "")) | ||
| if not layer_names: | ||
| index_offset = 1 | ||
| for idx in indices: | ||
| if "2" in lines[idx + index_offset]: | ||
| layer_names.append(lines[idx + index_offset + 1].replace("\n", "")) | ||
|
Comment on lines
+825
to
+828
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you explain the logic behind this code ? |
||
| return layer_names | ||
|
|
||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1433,7 +1433,7 @@ def _import_cad( | |
| aedb_path = aedb_path.replace(old_name, project_name) | ||
| self.logger.warning("aedb_exists. Renaming it to %s", project_name) | ||
| if xml_path is None: | ||
| xml_path = Path("").name | ||
| xml_path = str(Path(cad_path).with_suffix(".xml")) | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why are you casting into |
||
| elif Path(xml_path).suffix == ".tech": | ||
| xml_path = Path(tech_to_control_file(xml_path)).name | ||
| if cad_format == "gds": | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, add some tests to cover the new lines you implemented