Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define the interface for merging indexes #312

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

modify

1ca17b6
Select commit
Loading
Failed to load commit list.
Open

define the interface for merging indexes #312

modify
1ca17b6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 14, 2025 in 1s

88.18% (target 95.00%)

View this Pull Request on Codecov

88.18% (target 95.00%)

Details

Codecov Report

Attention: Patch coverage is 94.59459% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/engine.cpp 84.37% 5 Missing ⚠️
src/index/hnsw.cpp 93.93% 2 Missing ⚠️
src/index/hnsw_test.cpp 98.07% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #312       +/-   ##
=========================================
+ Coverage      0   88.18%   +88.18%     
=========================================
  Files         0      146      +146     
  Lines         0     9462     +9462     
=========================================
+ Hits          0     8344     +8344     
- Misses        0     1118     +1118     
Files with missing lines Coverage Δ
src/algorithm/hnswlib/hnswalg.cpp 87.34% <100.00%> (ø)
src/algorithm/hnswlib/hnswalg.h 96.87% <ø> (ø)
src/index/hnsw.h 100.00% <ø> (ø)
src/merge_index.cpp 100.00% <100.00%> (ø)
src/index/hnsw_test.cpp 98.54% <98.07%> (ø)
src/index/hnsw.cpp 90.74% <93.93%> (ø)
src/engine.cpp 89.79% <84.37%> (ø)

... and 139 files with indirect coverage changes