Fix virtual environment activation path on Windows#393
Open
yuribodo wants to merge 1 commit intoanthropics:mainfrom
Open
Fix virtual environment activation path on Windows#393yuribodo wants to merge 1 commit intoanthropics:mainfrom
yuribodo wants to merge 1 commit intoanthropics:mainfrom
Conversation
The setup.sh script was hardcoded to use .venv/bin/activate, which fails on Windows where Python creates .venv/Scripts/activate instead. This adds an OSTYPE check to select the correct path on msys/cygwin shells while preserving the existing behavior on Linux and macOS. Fixes anthropics#129
yuribodo
force-pushed
the
fix/windows-venv-activation-129
branch
from
3d63bb1 to
a6f70c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #129. The
computer-use-demo/setup.shscript hardcodedsource .venv/bin/activate, which works on Linux/macOS but fails on Windows (Git Bash / MSYS2 / Cygwin) where Python creates the activation script at.venv/Scripts/activateinstead.Change
Check which activation script the freshly-created venv actually contains, rather than trying to enumerate Windows bash variants via
$OSTYPE:This is self-documenting, doesn't maintain an OS taxonomy (
msysvsmsys2vscygwinvs ...), and matches what tools likeuvandhatchdo internally.Scope
This PR only fixes the
setup.shactivation step — the rest of the Windows story (Rust/cargo build, Docker runtime, pre-commit hooks) is out of scope and not claimed to be fixed here.Test plan
bash -n computer-use-demo/setup.shpasses syntax check.venv/Scripts/activatewon't exist, so theelsebranch runs exactly as before.venv/Scripts/activate, theifbranch sources it