Use ProgramError from Solana SDK
#112
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 27, 2025
febo
force-pushed
the
febo/sdk-program-error
branch
from
662299a to
fd9e12e
Compare
febo
force-pushed
the
febo/sdk-program-error
branch
2 times, most recently
from
fa49062 to
4100e84
Compare
rustopian
approved these changes
Sep 12, 2025
Contributor
rustopian
left a comment
rustopian
left a comment
There was a problem hiding this comment.
Straightforward, looks good
febo
force-pushed
the
febo/sdk-program-error
branch
from
4100e84 to
8077fe8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Pinocchio currently re-implements the
ProgramErrortype, which is essentially a copy of the same type from Solana SDK. This will make it awkward to write code that interact with both pinocchio and SDK types.Solution
Bring the
ProgramErrortype fromsolana-program-errorcrate. This adds a dependency to pinocchio – an "internal" dependency to a SDK crate.Note: this needs #250 to be merged first.