Skip to content

Conversation

@febo
Copy link
Collaborator

@febo febo commented Sep 12, 2025

Problem

Currently pinocchio packages are build with rust 1.79, which is quite old.

Solution

This PR bumps the MSRV to 1.84.11.84, which is a version compatible with Solana CLI 2.3+.

@febo febo marked this pull request as ready for review September 12, 2025 11:38
grod220
grod220 previously approved these changes Sep 12, 2025
Copy link

@grod220 grod220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

joncinque
joncinque previously approved these changes Sep 15, 2025
rustopian
rustopian previously approved these changes Sep 15, 2025
Copy link
Contributor

@rustopian rustopian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on my end.

@febo febo dismissed stale reviews from rustopian and joncinque via f1314ca September 21, 2025 00:52
@febo febo force-pushed the febo/toolchain-bump branch from f1314ca to 707de26 Compare September 21, 2025 09:33
Copy link
Collaborator

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants