-
Notifications
You must be signed in to change notification settings - Fork 59
Replace std::error::Error
with core::error::Error
#116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 1 commit
4472074
76809ec
1a01c22
d655e44
f444473
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -243,7 +243,7 @@ pub enum InstructionError { | |
} | ||
|
||
#[cfg(feature = "std")] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. one more place |
||
impl std::error::Error for InstructionError {} | ||
impl core::error::Error for InstructionError {} | ||
|
||
#[cfg(feature = "std")] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is also can be omitted, because this is a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Okay, I originally considered dropping these attributes, but I wasn't sure. Thank you for confirming. |
||
impl fmt::Display for InstructionError { | ||
|
@@ -442,7 +442,7 @@ pub enum LamportsError { | |
} | ||
|
||
#[cfg(feature = "std")] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. and this one also |
||
impl std::error::Error for LamportsError {} | ||
impl core::error::Error for LamportsError {} | ||
|
||
impl fmt::Display for LamportsError { | ||
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -103,7 +103,7 @@ impl FromPrimitive for PubkeyError { | |
} | ||
|
||
#[cfg(feature = "std")] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. and here |
||
impl std::error::Error for PubkeyError {} | ||
impl core::error::Error for PubkeyError {} | ||
|
||
impl fmt::Display for PubkeyError { | ||
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { | ||
|
@@ -361,7 +361,7 @@ impl FromPrimitive for ParsePubkeyError { | |
} | ||
|
||
#[cfg(feature = "std")] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the same here |
||
impl std::error::Error for ParsePubkeyError {} | ||
impl core::error::Error for ParsePubkeyError {} | ||
|
||
impl fmt::Display for ParsePubkeyError { | ||
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i guess it can be dropped