Fixup build: remove stake-interface, bring system-interface back #264

joncinque · 2025-08-05T11:42:03Z

Problem

The build is currently failing due to circular dependencies between the sdk, system-interface, and stake-interface. This is totally normal since we're publishing breaking changes, but in general, these circular dependencies can be tricky to manage. See #263 for more info.

Summary of changes

Remove the circular dependencies for good:

BREAKING: remove stake-interface from the sysvar crate
bring system-interface back into the repo
update system-interface based on breaking changes currently in the sdk
remove all patches from the sdk toml

Work to do after:

add back the wasm-js code for the system interface via a new crate
fix up solana-stake-interface to implement the sysvar trait once all the crates have been published

#### Problem The circular dependencies between the sdk, system-interface, and stake-interface make crate publishing very tricky, especially around breaking changes. #### Summary of changes To start breaking the chain, remove stake-interface from the repo. stake-interface will implement the sysvar trait itself as part of the next breaking change.

#### Problem Too many sdk crates depend on the system interface, which makes updating, building, and publishing a big headache. #### Summary of changes Declare defeat, and add the system interface back into the sdk repo. This will also remove circular dependencies completely, and make publishing a pleasure once again.

github-actions · 2025-08-05T11:42:12Z

If this PR represents a change to the sysvar layout, please open a follow-up PR to update the JavaScript client @solana/sysvars (example)
Thank you for keeping the JavaScript clients in sync with the Rust clients.

github-actions · 2025-08-05T11:44:51Z

If this PR represents a change to the sysvar layout, please open a follow-up PR to update the JavaScript client @solana/sysvars (example)
Thank you for keeping the JavaScript clients in sync with the Rust clients.

github-actions · 2025-08-05T11:48:16Z

If this PR represents a change to the sysvar layout, please open a follow-up PR to update the JavaScript client @solana/sysvars (example)
Thank you for keeping the JavaScript clients in sync with the Rust clients.

github-actions · 2025-08-05T11:57:30Z

If this PR represents a change to the sysvar layout, please open a follow-up PR to update the JavaScript client @solana/sysvars (example)
Thank you for keeping the JavaScript clients in sync with the Rust clients.

github-actions · 2025-08-05T12:33:51Z

If this PR represents a change to the sysvar layout, please open a follow-up PR to update the JavaScript client @solana/sysvars (example)
Thank you for keeping the JavaScript clients in sync with the Rust clients.

github-actions · 2025-08-05T12:35:33Z

If this PR represents a change to the sysvar layout, please open a follow-up PR to update the JavaScript client @solana/sysvars (example)
Thank you for keeping the JavaScript clients in sync with the Rust clients.

joncinque · 2025-08-05T12:36:12Z

example-mocks/Cargo.toml

+[features]
+bincode = ["solana-system-interface/bincode"]


This change looks unrelated, but it's unfortunately needed.

The docs build fails without it, because example-mocks is re-exporting from system-interface, but doesn't have the bincode feature enabled, which means that the instructions referenced in the docs don't exist.

joncinque · 2025-08-05T12:36:51Z

Cargo.toml

-[patch.crates-io]
-# We include the following crates as our dependencies above from crates.io:
-#
-#  * solana-system-interface
-#
-# They, in turn, depend on a number of crates that we also include directly
-# using `path` specifications.  For example, `solana-system-interface` depends
-# on `solana-instruction`.  And we explicitly specify `solana-instruction` above
-# as a local path dependency:
-#
-#     solana-instruction = { path = "instruction", version = "2.2.1" }
-#
-# Unfortunately, Cargo will try to resolve the `solana-system-interface`
-# `solana-instruction` dependency only using what is available on crates.io.
-# Crates.io normally contains a previous version of these crates, and we end up
-# with two versions of `solana-instruction` and all of their dependencies in our
-# build tree.
-#
-# If you are developing downstream using non-crates-io solana-program (local or
-# forked repo, or from github rev, eg), duplicate the following patch statements
-# in your Cargo.toml. If you still hit duplicate-type errors with the patch
-# statements in place, run `cargo update -p solana-program` to remove extraneous
-# versions from your Cargo.lock file.
-solana-account = { path = "account" }
-solana-clock = { path = "clock" }
-solana-cpi = { path = "cpi" }
-solana-frozen-abi = { path = "frozen-abi" }
-solana-frozen-abi-macro = { path = "frozen-abi-macro" }
-solana-instruction = { path = "instruction" }
-solana-program-error = { path = "program-error" }
-solana-pubkey = { path = "pubkey" }
-solana-rent = { path = "rent" }
-solana-signature = { path = "signature" }
-solana-sysvar-id = { path = "sysvar-id" }


This is the best part of this change, and the whole motivation

github-actions · 2025-08-05T13:17:20Z

If this PR represents a change to the sysvar layout, please open a follow-up PR to update the JavaScript client @solana/sysvars (example)
Thank you for keeping the JavaScript clients in sync with the Rust clients.

joncinque · 2025-08-05T13:18:40Z

system-interface/src/instruction.rs

+//! [`Instruction`]:
+//! https://docs.rs/solana-instruction/latest/solana_instruction/struct.Instruction.html


This is the only change in this file

joncinque · 2025-08-05T13:19:32Z

sysvar/src/lib.rs

 /// Handler for retrieving a slice of sysvar data from the `sol_get_sysvar`
 /// syscall.
-fn get_sysvar(
+pub fn get_sysvar(


We'll need this function when reimplementing the moved logic in solana-stake-interface, so make it public

joncinque · 2025-08-05T13:19:59Z

sysvar/Cargo.toml

 solana-frozen-abi-macro = { workspace = true, optional = true }
 solana-hash = { workspace = true, features = ["bytemuck"] }
-solana-instruction = { workspace = true }
+solana-instruction = { workspace = true, features = ["std"] }


This was being enabled through solana-stake-interface

github-actions · 2025-08-05T13:27:54Z

If this PR represents a change to the sysvar layout, please open a follow-up PR to update the JavaScript client @solana/sysvars (example)
Thank you for keeping the JavaScript clients in sync with the Rust clients.

rustopian

Looks good. Some improvements to error.rs, rm wasm as you mentioned, otherwise diffs are clean.

I noticed one sort-of-broken link in the docs. Up to you.

rustopian · 2025-08-05T17:11:36Z

system-interface/README.md

+
+# Solana System Interface
+
+This crate contains instructions and constructors for interacting with the [System program](https://docs.solanalabs.com/runtime/programs#system-program).


Not really essential to this PR, but

Suggested change

This crate contains instructions and constructors for interacting with the [System program](https://docs.solanalabs.com/runtime/programs#system-program).

This crate contains instructions and constructors for interacting with the [System program](https://solana.com/docs/core/programs#core-programs).

The old link has an awkward redirect notice... which arguably takes you to the wrong page anyway (account model).

Works for me!

github-actions · 2025-08-05T21:12:36Z

If this PR represents a change to the sysvar layout, please open a follow-up PR to update the JavaScript client @solana/sysvars (example)
Thank you for keeping the JavaScript clients in sync with the Rust clients.

#### Problem The stake-history module in solana-sysvar will be removed with anza-xyz#264, but there hasn't been a deprecation warning. #### Summary of changes Put in a deprecation warning.

joncinque · 2025-08-05T22:01:18Z

For what it's worth, I know it kind of stinks to not use the program-specific repo for the system interface, but it's just too tied into the rest of the sdk unfortunately.

I prefer the sanity of a self-contained repo over splitting things up. It'll also mean that tools like cargo-semver-checks just work, instead of requiring fixes or hacks on our side.

Also, since the plans for a BPF system program have been put on hold for a long time, the program-specific repo becomes a bit less necessary for the rust crates. We can certainly keep hosting the idl and kit library though.

* sysvar: Deprecate stake-history and functions #### Problem The stake-history module in solana-sysvar will be removed with #264, but there hasn't been a deprecation warning. #### Summary of changes Put in a deprecation warning. * Improve deprecation notice

#### Problem As part of the upgrade to SDK v3, the cyclical dependency between the sdk crates and the system interface were too much of an annoyance, so the interface was migrated back into the SDK with anza-xyz/solana-sdk#264. But the interface code still lives in this repo as well. #### Summary of changes Remove the interface crate and all references to it.

…a-xyz#264) * sysvar!: Remove stake-interface dependency The circular dependencies between the sdk, system-interface, and stake-interface make crate publishing very tricky, especially around breaking changes. To start breaking the chain, remove stake-interface from the repo. stake-interface will implement the sysvar trait itself as part of the next breaking change. * system-interface: Add back into the sdk repo Too many sdk crates depend on the system interface, which makes updating, building, and publishing a big headache. Declare defeat, and add the system interface back into the sdk repo. This will also remove circular dependencies completely, and make publishing a pleasure once again. * system-interface: Fixup post-migration * Add feature required for solana-instruction * Run cargo sort, specify circular dev deps with path * Pacify dep checker by specifying path dependency * Fixup docs build * Fix doc / powerset build issues * Run doctests with all features * Update broken link

joncinque added 3 commits August 5, 2025 13:36

system-interface: Fixup post-migration

e695c63

joncinque requested a review from buffalojoec August 5, 2025 11:42

Add feature required for solana-instruction

e7db5c4

joncinque mentioned this pull request Aug 5, 2025

CI: Don't run clippy during publish #263

Closed

joncinque requested a review from rustopian August 5, 2025 11:45

Run cargo sort, specify circular dev deps with path

16943e6

Pacify dep checker by specifying path dependency

626033b

Fixup docs build

e1eed08

joncinque force-pushed the rm-stake-interface branch from 9be72f2 to e1eed08 Compare August 5, 2025 12:35

joncinque commented Aug 5, 2025

View reviewed changes

Fix doc / powerset build issues

46c5d14

joncinque commented Aug 5, 2025

View reviewed changes

Run doctests with all features

8d3bb6a

rustopian previously approved these changes Aug 5, 2025

View reviewed changes

joncinque mentioned this pull request Aug 5, 2025

signature: add optional bytemuck support #265

Merged

Update broken link

c32315c

joncinque dismissed rustopian’s stale review via c32315c August 5, 2025 21:12

joncinque mentioned this pull request Aug 5, 2025

sysvar: Deprecate stake-history and functions #266

Merged

rustopian mentioned this pull request Aug 6, 2025

Use sol_get_sysvar instead of sol_get_<NAME>_sysvar #257

Merged

rustopian self-requested a review August 6, 2025 15:05

rustopian approved these changes Aug 6, 2025

View reviewed changes

rustopian mentioned this pull request Aug 6, 2025

Fix offline message signing in CLI (align to spec) #269

Draft

joncinque merged commit 8d94267 into anza-xyz:master Aug 6, 2025
26 checks passed

joncinque deleted the rm-stake-interface branch August 6, 2025 17:32

joncinque mentioned this pull request Aug 20, 2025

interface: Remove from the repo solana-program/system#55

Merged

		//! [`Instruction`]:
		//! https://docs.rs/solana-instruction/latest/solana_instruction/struct.Instruction.html


		# Solana System Interface

		This crate contains instructions and constructors for interacting with the [System program](https://docs.solanalabs.com/runtime/programs#system-program).

Fixup build: remove stake-interface, bring system-interface back #264

Fixup build: remove stake-interface, bring system-interface back #264

Uh oh!

Conversation

joncinque commented Aug 5, 2025

Problem

Summary of changes

Uh oh!

github-actions bot commented Aug 5, 2025

Uh oh!

github-actions bot commented Aug 5, 2025

Uh oh!

github-actions bot commented Aug 5, 2025

Uh oh!

github-actions bot commented Aug 5, 2025

Uh oh!

github-actions bot commented Aug 5, 2025

Uh oh!

github-actions bot commented Aug 5, 2025

Uh oh!

joncinque Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

joncinque Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 5, 2025

Uh oh!

joncinque Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

joncinque Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

joncinque Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 5, 2025

Uh oh!

rustopian left a comment

Choose a reason for hiding this comment

Uh oh!

rustopian Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joncinque Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 5, 2025

Uh oh!

joncinque commented Aug 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rustopian Aug 5, 2025 •

edited

Loading