[bn254] Add _be suffix to BE functions #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@samkim-crypto Could you please review this PR? I want to rebase #334 on it. |
Contributor
samkim-crypto
left a comment
samkim-crypto
left a comment
There was a problem hiding this comment.
Sorry for the delay on this. Everything looks good to me!
Seems like a new CI workflow was added in #340, so there is some issue with the no_std workflow starting. Do you mind rebasing master? I'll start the CI when you do and hopefully that starts the no_std workflow.
samkim-crypto
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@samkim-crypto I also added
g1to addition and multiplication as a preparation to SIMD-0302.