Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try mkdir for final destination before in WriteFiles #31690

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Try mkdir for final destination before in WriteFiles #31690

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d3ba8c
Try mkdir for final destination before in WriteFiles
Abacn Jun 26, 2024
3d9405b
debug log when fail mkdir
Abacn Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions sdks/python/apache_beam/io/fileio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,6 +708,14 @@ def process(self, element, w=beam.DoFn.WindowParam):
self.path.get(),
move_to)

try:
filesystems.FileSystems.mkdirs(self.path.get())
except IOError as e:
cause = repr(e)
if 'FileExistsError' not in cause:
# Usually harmless. Especially if see FileExistsError so no need to log
_LOGGER.debug('Fail to create dir for final destination: %s', cause)

try:
filesystems.FileSystems.rename(
move_from,
Expand Down
Loading