Update SpannerIO.java - comment documentation#38492
Conversation
Spanner supports 80,000 mutations per transacton https://docs.cloud.google.com/spanner/quotas#limits_for_creating_reading_updating_and_deleting_data:~:text=Mutations%20per%20commit
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the documentation within SpannerIO.java to accurately reflect the current Cloud Spanner mutation limit per transaction, increasing the documented value from 20,000 to 80,000 to align with official Google Cloud documentation. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Javadoc documentation in SpannerIO.java to reflect the increased Spanner transaction limit of 80,000 mutated cells. Feedback suggests that the DEFAULT_MAX_NUM_MUTATIONS constant should also be updated to match the documentation and recommends using 'number of mutations' instead of 'size' to prevent confusion with the 100MB commit size limit.
| * <p>Note that the <a | ||
| * href="https://cloud.google.com/spanner/quotas#limits_for_creating_reading_updating_and_deleting_data">maximum | ||
| * size of a single transaction</a> is 20,000 mutated cells - including cells in indexes. If you | ||
| * size of a single transaction</a> is 80,000 mutated cells - including cells in indexes. If you |
There was a problem hiding this comment.
The documentation update to 80,000 is correct, but the change is incomplete. The DEFAULT_MAX_NUM_MUTATIONS constant in this class should also be updated to 80,000 to ensure the default behavior matches the documentation. Additionally, consider using 'number of mutations' instead of 'size' to avoid confusion with the separate 100MB commit size limit. Finally, please update the PR description to remove the placeholder text and fix the typo ('transacton').
| * size of a single transaction</a> is 80,000 mutated cells - including cells in indexes. If you | |
| * number of mutations in a single transaction</a> is 80,000 mutations - including mutations in indexes. If you |
|
Assigning reviewers: R: @chamikaramj for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
1 participant
Spanner supports 80,000 mutations per transacton
https://docs.cloud.google.com/spanner/quotas#limits_for_creating_reading_updating_and_deleting_data:~:text=Mutations%20per%20commit
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.