Skip to content

Update SpannerIO.java - comment documentation #38492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
googledrew wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

Update SpannerIO.java - comment documentation #38492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@
*
* <p>Note that the <a
* href="https://cloud.google.com/spanner/quotas#limits_for_creating_reading_updating_and_deleting_data">maximum
* size of a single transaction</a> is 20,000 mutated cells - including cells in indexes. If you
* size of a single transaction</a> is 80,000 mutated cells - including cells in indexes. If you
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The documentation update to 80,000 is correct, but the change is incomplete. The DEFAULT_MAX_NUM_MUTATIONS constant in this class should also be updated to 80,000 to ensure the default behavior matches the documentation. Additionally, consider using 'number of mutations' instead of 'size' to avoid confusion with the separate 100MB commit size limit. Finally, please update the PR description to remove the placeholder text and fix the typo ('transacton').

Suggested change
* size of a single transaction</a> is 80,000 mutated cells - including cells in indexes. If you
* number of mutations in a single transaction</a> is 80,000 mutations - including mutations in indexes. If you

* have a large number of indexes and are getting exceptions with message: <tt>INVALID_ARGUMENT: The
* transaction contains too many mutations</tt> you will need to specify a smaller number of {@code
* MaxNumMutations}.
Expand Down
Loading