[Calcite 3558] Fixing indexing variable for the column reordering loop #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync with the master branch
Sync with the Calcite master branch (5/29/2019)
sync with calcite master
Sync with the remote master
Branch 1.21
latest master 12/3/2019
chunweilei
reviewed
Dec 4, 2019
| @@ -243,6 +243,7 @@ protected RelNode appendSearchString( | |||
| field = topFields.get(i); | |||
| } | |||
| newFields.add(field); | |||
| i++; | |||
| } | |||
There was a problem hiding this comment.
Could you please add a test?
There was a problem hiding this comment.
And change the commit message to the problem being fixed, not the code change you made to fix it.
There was a problem hiding this comment.
I will update test cases and commit message.
chunweilei
added
the
returned-with-feedback
vlsi
force-pushed
the
master
branch
2 times, most recently
from
49cb002 to
8768a23
Compare
julianhyde
force-pushed
the
main
branch
2 times, most recently
from
8a5cf83 to
cf7f71b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just simply put i++ in the loop to make the loop work properly.