[CALCITE-1962] Changes SqlOrderBy unparse method to use the SqlPrettyWriter.fetchOffset #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et method, which correctly writes dialect specific offset/fetch/limit statements.
pauloriordan
changed the title
|
-1 See conversation at https://issues.apache.org/jira/browse/CALCITE-1962. |
|
@julianhyde Do you still maintain a -1 for this PR? If so, can we close this? |
|
Let's discuss in the JIRA case. |
vlsi
added
returned-with-feedback
danny0405
force-pushed
the
master
branch
2 times, most recently
from
80f411d to
ca27fe9
Compare
vlsi
force-pushed
the
master
branch
2 times, most recently
from
49cb002 to
8768a23
Compare
|
What is the final conclusion of this question |
|
@sunnyz-l, @pauloriordan, Let's discuss in https://issues.apache.org/jira/browse/CALCITE-1962. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes SqlOrderBy's unparse method to use the SqlPrettyWriter.fetchOffset which writes dialect specific fetch/offset/limit statements.