Skip to content

[MINOR] Fix PbSerDeUtilsTest failure#3722

Closed
s0nskar wants to merge 1 commit into
apache:mainfrom
s0nskar:CELEBORN-1577_fix_test
Closed

[MINOR] Fix PbSerDeUtilsTest failure#3722
s0nskar wants to merge 1 commit into
apache:mainfrom
s0nskar:CELEBORN-1577_fix_test

Conversation

@s0nskar

@s0nskar s0nskar commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Fix PbSerDeUtilsTest failure for spark4 jobs

Error:  /home/runner/work/celeborn/celeborn/common/src/test/scala/org/apache/celeborn/common/util/PbSerDeUtilsTest.scala:851: comparing values of types Boolean and Boolean using `equals` unsafely bypasses cooperative equality; use `==` instead
Error: [ERROR] one error found

https://github.com/apache/celeborn/actions/runs/27126367363/job/80055898287?pr=3720

Why are the changes needed?

After this change #3675, some of tests are failing.

Does this PR resolve a correctness bug?

  • Yes

Does this PR introduce any user-facing change?

  • Yes

How was this patch tested?

Existing UTs.

@SteNicholas

Copy link
Copy Markdown
Member

Thanks for fix. Merged to main(v0.7.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants