Skip to content

Add the PAX support in the configure #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

Add the PAX support in the configure #19

merged 1 commit into from
May 22, 2025

Conversation

tuhaihe
Copy link
Member

@tuhaihe tuhaihe commented Apr 30, 2025

No description provided.

@tuhaihe tuhaihe mentioned this pull request Apr 30, 2025
Merged
12 tasks
@tuhaihe
Copy link
Member Author

tuhaihe commented Apr 30, 2025

The PR is a requirement for apache/cloudberry#1081.

@tuhaihe tuhaihe requested a review from edespino April 30, 2025 08:46
@leborchuk
Copy link

I see that all tests in apache/cloudberry#1081 failed with

psql: error: connection to server on socket "/tmp/.s.PGSQL.7000" failed: FATAL:  invalid value for parameter "default_table_access_method": "pax"
DETAIL:  Table access method "pax" does not exist.

I believe this fix should fix it - is it so?

@leborchuk
Copy link

I also see the errors in installing RPM

Error: 
 Problem: package perl-4:5.32.1-481.el9.x86_64 from appstream requires perl-ExtUtils-CBuilder, but none of the providers can be installed
  - package perl-ExtUtils-CBuilder-1:0.280236-4.el9.noarch from appstream requires gcc, but none of the providers can be installed
  - package apache-cloudberry-db-incubating-99.0.0-1.el9.x86_64 from @commandline requires perl, but none of the providers can be installed
  - package gcc-11.5.0-5.el9_5.x86_64 from appstream requires glibc-devel >= 2.2.90-12, but none of the providers can be installed
  - conflicting requests
  - nothing provides glibc = 2.34-125.el9_5.3 needed by glibc-devel-2.34-125.el9_5.3.x86_64 from appstream
  - nothing provides glibc = 2.34-125.el9_5.3 needed by glibc-devel-2.34-125.el9_5.3.i686 from appstream

Where are these errors going to be fixed? Maybe it will be better to fix them in these PR too ...

@tuhaihe
Copy link
Member Author

tuhaihe commented May 9, 2025

Hi @leborchuk, the discussion on changing PAX to be disabled by default is in the following thread: https://lists.apache.org/thread/q1n7hztzzydk1owhn73tc1b4chyhzx85. You are welcome to share your thoughts on this. If we agree, these issues will be resolved after this PR is merged.

@tuhaihe tuhaihe force-pushed the enable-pax branch 2 times, most recently from dda005b to f8c3298 Compare May 14, 2025 04:53
@tuhaihe
Copy link
Member Author

tuhaihe commented May 14, 2025

Now it’s ready for review (at least for Rocky 9). @leborchuk @edespino

For building PAX in Rocky 8, has one issue tracked at apache/cloudberry#1097.

@tuhaihe tuhaihe requested a review from jiaqizho May 15, 2025 06:51
@tuhaihe
Copy link
Member Author

tuhaihe commented May 15, 2025

Also, need to upgrade gcc from 8 to 11. Will update this PR later.

@tuhaihe
Copy link
Member Author

tuhaihe commented May 16, 2025

Also, need to upgrade gcc from 8 to 11. Will update this PR later.

Done. PTAL.

@tuhaihe
Add the PAX support in the configure
2c2465a 
PAX is a new access method introduced by Cloudberry since 2.0.0. In
this PR, add the `--enable-pax` option to the configure command to
enable PAX support when building Cloudberry.

Other changes:
* add `cmake3` as the dependency for building PAX in Rocky8.
* Install and set gcc/gcc-c++ 11 as the compiler for building PAX.
@tuhaihe tuhaihe requested a review from gfphoenix78 May 19, 2025 03:15
@tuhaihe tuhaihe mentioned this pull request May 20, 2025
Closed
2 tasks
edespino
edespino approved these changes May 22, 2025
View reviewed changes
Copy link
Contributor

@edespino edespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 - Thank you for this.

@tuhaihe tuhaihe merged commit 3842028 into apache:main May 22, 2025
@tuhaihe tuhaihe mentioned this pull request May 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edespino edespino edespino approved these changes

@jiaqizho jiaqizho Awaiting requested review from jiaqizho

@gfphoenix78 gfphoenix78 Awaiting requested review from gfphoenix78

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuhaihe @leborchuk @edespino