Change PAX Plugin to Be Disabled by Default #1081
Merged
+16
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR relies on the apache/cloudberry-devops-release#19 |
This was referenced May 12, 2025
|
The file |
Yes, it does, generated by autoconf 2.69. |
gfphoenix78
reviewed
May 20, 2025
tuhaihe
force-pushed
the
pax-disable-default-fix
branch
from
0e639fb to
07c0aed
Compare
12 tasks
|
Hey everyone, I'm looking forward to your review and approval for this PR again. The base PR apache/cloudberry-devops-release#19 has been merged, and the PAX-related tests have now passed. Thanks! @jiaqizho @gfphoenix78 @gongxun0928 @edespino |
2 tasks
yjhjstz
reviewed
May 23, 2025
my-ship-it
approved these changes
May 23, 2025
Currently, the PAX is enabled by default in configure, and users need to explicitly disable it via `--disable-pax` option. However, this behavior is inconsistent with most of the other extensions under the contrib/ or gpcontrib/ dir, which are typically disabled by default unless explicitly enabled. PAX currently requires downloading several submodules during the build, for users without prior knowledge, this will lead to build failures. This PR is to change the default behavior of PAX to disabled, which will be more user-friendly for users. See: https://lists.apache.org/thread/q1n7hztzzydk1owhn73tc1b4chyhzx85
tuhaihe
force-pushed
the
pax-disable-default-fix
branch
from
07c0aed to
9e37790
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the PAX is enabled by default in configure, and users need to explicitly disable it via
--disable-paxoption. However, this behavior is inconsistent with most of the other extensions under the contrib/ or gpcontrib/ dir, which are typically disabled by default unless explicitly enabled.PAX currently requires downloading several submodules during the build, for users without prior knowledge, this will lead to build failures.
This PR is to change the default behavior of PAX to disabled, which will be more user-friendly for users.
See: https://lists.apache.org/thread/q1n7hztzzydk1owhn73tc1b4chyhzx85
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions