Skip to content

[WIP] Allow CIDR update for the shared network when the network IPs are not in use #10839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sureshanaparti wants to merge 1 commit into from

Allow CIDR update for the shared network when the network IPs are not…

1af11e6
Select commit
Loading
Failed to load commit list.
Closed

[WIP] Allow CIDR update for the shared network when the network IPs are not in use #10839

Allow CIDR update for the shared network when the network IPs are not…
1af11e6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed May 14, 2025 in 0s

4.28% (-10.89%) compared to f0838cd

View this Pull Request on Codecov

4.28% (-10.89%) compared to f0838cd

Details

Codecov Report

Attention: Patch coverage is 2.00000% with 49 lines in your changes missing coverage. Please review.

Project coverage is 4.28%. Comparing base (f0838cd) to head (1af11e6).
Report is 10 commits behind head on 4.19.

Files with missing lines Patch % Lines
...ain/java/com/cloud/network/NetworkServiceImpl.java 0.00% 41 Missing ⚠️
...ema/src/main/java/com/cloud/vm/dao/NicDaoImpl.java 12.50% 7 Missing ⚠️
.../java/com/cloud/network/guru/GuestNetworkGuru.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##               4.19   #10839       +/-   ##
=============================================
- Coverage     15.17%    4.28%   -10.89%     
=============================================
  Files          5414      371     -5043     
  Lines        475185    29700   -445485     
  Branches      57991     5211    -52780     
=============================================
- Hits          72105     1274    -70831     
+ Misses       395018    28281   -366737     
+ Partials       8062      145     -7917

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov