Skip to content

[WIP] Allow CIDR update for the shared network when the network IPs are not in use #10839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sureshanaparti wants to merge 1 commit into from

Allow CIDR update for the shared network when the network IPs are not…

1af11e6
Select commit
Loading
Failed to load commit list.
Closed

[WIP] Allow CIDR update for the shared network when the network IPs are not in use #10839

Allow CIDR update for the shared network when the network IPs are not…
1af11e6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed May 14, 2025 in 1s

2.00% of diff hit (target 15.17%)

View this Pull Request on Codecov

2.00% of diff hit (target 15.17%)

Annotations

Check warning on line 162 in engine/schema/src/main/java/com/cloud/vm/dao/NicDaoImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

engine/schema/src/main/java/com/cloud/vm/dao/NicDaoImpl.java#L156-L162 

Added lines #L156 - L162 were not covered by tests

Check warning on line 3093 in server/src/main/java/com/cloud/network/NetworkServiceImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/com/cloud/network/NetworkServiceImpl.java#L3093 

Added line #L3093 was not covered by tests

Check warning on line 3100 in server/src/main/java/com/cloud/network/NetworkServiceImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/com/cloud/network/NetworkServiceImpl.java#L3100 

Added line #L3100 was not covered by tests

Check warning on line 3103 in server/src/main/java/com/cloud/network/NetworkServiceImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/com/cloud/network/NetworkServiceImpl.java#L3103 

Added line #L3103 was not covered by tests

Check warning on line 3139 in server/src/main/java/com/cloud/network/NetworkServiceImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/com/cloud/network/NetworkServiceImpl.java#L3135-L3139 

Added lines #L3135 - L3139 were not covered by tests

Check warning on line 3141 in server/src/main/java/com/cloud/network/NetworkServiceImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/com/cloud/network/NetworkServiceImpl.java#L3141 

Added line #L3141 was not covered by tests

Check warning on line 3144 in server/src/main/java/com/cloud/network/NetworkServiceImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/com/cloud/network/NetworkServiceImpl.java#L3144 

Added line #L3144 was not covered by tests

Check warning on line 3146 in server/src/main/java/com/cloud/network/NetworkServiceImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/com/cloud/network/NetworkServiceImpl.java#L3146 

Added line #L3146 was not covered by tests

Check warning on line 3150 in server/src/main/java/com/cloud/network/NetworkServiceImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/com/cloud/network/NetworkServiceImpl.java#L3150 

Added line #L3150 was not covered by tests

Check warning on line 3152 in server/src/main/java/com/cloud/network/NetworkServiceImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/com/cloud/network/NetworkServiceImpl.java#L3152 

Added line #L3152 was not covered by tests

Check warning on line 3154 in server/src/main/java/com/cloud/network/NetworkServiceImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/com/cloud/network/NetworkServiceImpl.java#L3154 

Added line #L3154 was not covered by tests

Check warning on line 3158 in server/src/main/java/com/cloud/network/NetworkServiceImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/com/cloud/network/NetworkServiceImpl.java#L3156-L3158 

Added lines #L3156 - L3158 were not covered by tests

Check warning on line 3160 in server/src/main/java/com/cloud/network/NetworkServiceImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/com/cloud/network/NetworkServiceImpl.java#L3160 

Added line #L3160 was not covered by tests

Check warning on line 3204 in server/src/main/java/com/cloud/network/NetworkServiceImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/com/cloud/network/NetworkServiceImpl.java#L3203-L3204 

Added lines #L3203 - L3204 were not covered by tests

Check warning on line 3208 in server/src/main/java/com/cloud/network/NetworkServiceImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/com/cloud/network/NetworkServiceImpl.java#L3208 

Added line #L3208 was not covered by tests

Check warning on line 3213 in server/src/main/java/com/cloud/network/NetworkServiceImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/com/cloud/network/NetworkServiceImpl.java#L3212-L3213 

Added lines #L3212 - L3213 were not covered by tests

Check warning on line 3216 in server/src/main/java/com/cloud/network/NetworkServiceImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/com/cloud/network/NetworkServiceImpl.java#L3215-L3216 

Added lines #L3215 - L3216 were not covered by tests

Check warning on line 447 in server/src/main/java/com/cloud/network/guru/GuestNetworkGuru.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/com/cloud/network/guru/GuestNetworkGuru.java#L447 

Added line #L447 was not covered by tests
View more details on Codecov