fixed operator precedence bug in setPosition() calls#253
Merged
leerho merged 1 commit intoapache:fix_setPositionfrom Jan 30, 2025
Merged
fixed operator precedence bug in setPosition() calls#253leerho merged 1 commit intoapache:fix_setPositionfrom
leerho merged 1 commit intoapache:fix_setPositionfrom
Conversation
Member
|
Thank you! This was an important find! And thank you for providing a test! And thanks for checking this before it was released! Whew! I will probably merge this into a separate branch before merging into main. |
leerho
added a commit
that referenced
this pull request
Feb 1, 2025
fixed operator precedence bug in setPosition() calls
Merged
Member
|
@pawel-wiejacha, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bug introduced by ff0fbe3