FINERACT-2354: Re-aging Interest Handling Option: Equal Amortization #5102
+4,301
−149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somasorosdpc
changed the title
somasorosdpc
force-pushed
the
FINERACT-2354/Re-aging--InterestHandlingOption-EqualAmortization
branch
3 times, most recently
from
57ebadc to
acc6f6e
Compare
somasorosdpc
changed the title
somasorosdpc
force-pushed
the
FINERACT-2354/Re-aging--InterestHandlingOption-EqualAmortization
branch
from
1a8c3d3 to
9f0c90c
Compare
somasorosdpc
force-pushed
the
FINERACT-2354/Re-aging--InterestHandlingOption-EqualAmortization
branch
from
162e543 to
90f37e7
Compare
adamsaghy
reviewed
Nov 3, 2025
| createPaymentAllocation("MERCHANT_ISSUED_REFUND", "REAMORTIZATION"), // | ||
| createPaymentAllocation("PAYOUT_REFUND", "NEXT_INSTALLMENT")))// | ||
| .multiDisburseLoan(true)// | ||
| .disallowExpectedDisbursements(false)// |
There was a problem hiding this comment.
why do we need "expected disbursements"?
adamsaghy
reviewed
Nov 3, 2025
| AND lt.typeOf = :type | ||
| AND lt.dateOf <= :onDate | ||
| """) | ||
| Optional<LoanTransaction> findNonReversedTransactionActiveOnDate(@Param("loan") Loan loan, @Param("type") LoanTransactionType type, |
There was a problem hiding this comment.
what findNonReversedTransactionActiveOnDate method is for?
adamsaghy
reviewed
Nov 3, 2025
| || !transaction.isNonMonetaryTransaction() || transaction.isContractTermination()); | ||
| } | ||
|
|
||
| public Optional<LoanTransaction> getActiveReageTransactionOnDate(Loan loan, LocalDate onDate) { |
There was a problem hiding this comment.
A loan can have multiple reage txn. The only restriction is we cannot have multiple reage on the same date, but otherwise we can have as many reage as many we need.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.