[server] Introduce new rebalance API #1380
Conversation
swuferhong
force-pushed
the
reblance-api
branch
2 times, most recently
from
367414b to
c70310a
Compare
fluss-server/src/main/java/com/alibaba/fluss/server/zk/data/RebalancePlan.java
Outdated
Show resolved
Hide resolved
swuferhong
force-pushed
the
reblance-api
branch
7 times, most recently
from
ac2f7eb to
8b604e4
Compare
swuferhong
force-pushed
the
reblance-api
branch
2 times, most recently
from
291382b to
edb52c5
Compare
polyzos
force-pushed
the
main
branch
3 times, most recently
from
d88c76c to
434a4f4
Compare
swuferhong
force-pushed
the
reblance-api
branch
2 times, most recently
from
7ab4dcb to
a60f459
Compare
swuferhong
force-pushed
the
reblance-api
branch
from
a60f459 to
f2e8744
Compare
LiebingYu
left a comment
LiebingYu
left a comment
There was a problem hiding this comment.
Left some minor comments.
fluss-client/src/main/java/org/apache/fluss/client/admin/Admin.java
Outdated
Show resolved
Hide resolved
fluss-client/src/main/java/org/apache/fluss/client/admin/Admin.java
Outdated
Show resolved
Hide resolved
fluss-client/src/main/java/org/apache/fluss/client/admin/Admin.java
Outdated
Show resolved
Hide resolved
fluss-rpc/src/main/java/org/apache/fluss/rpc/protocol/Errors.java
Outdated
Show resolved
Hide resolved
swuferhong
force-pushed
the
reblance-api
branch
from
e879be6 to
72579c8
Compare
swuferhong
force-pushed
the
reblance-api
branch
from
72579c8 to
4f69637
Compare
wuchong
left a comment
wuchong
left a comment
There was a problem hiding this comment.
Thanks @swuferhong , I left some comments.
fluss-client/src/main/java/org/apache/fluss/client/admin/Admin.java
Outdated
Show resolved
Hide resolved
fluss-client/src/main/java/org/apache/fluss/client/admin/Admin.java
Outdated
Show resolved
Hide resolved
fluss-common/src/main/java/org/apache/fluss/cluster/rebalance/RebalanceStatusForBucket.java
Outdated
Show resolved
Hide resolved
fluss-common/src/main/java/org/apache/fluss/cluster/rebalance/RebalanceStatusForBucket.java
Outdated
Show resolved
Hide resolved
| return getOrEmpty(path).map(RebalanceZNode::decode); | ||
| } | ||
|
|
||
| public void deleteRebalancePlan() throws Exception { |
There was a problem hiding this comment.
I doubt whether we should delete the rebalance node on ZK. If we delete it once the rebalance successfully finished, we don't have the ability to respond users the status of the rebalance plan.
Maybe we can just soft delete the rebalance node by mark the rebalance plan is cancelled or failed or completed (the RebalanceStatus), so listRebalanceProgress still work after the rebalance finished, and can be overriden by next rebalance task.
There was a problem hiding this comment.
I agree with your changes. I've removed the deleteRebalancePlan method and added a new updateRebalancePlan method. Additionally, I introduced a new field rebalance_status in the RebalancePlan. Now, each time we check the status to determine whether the rebalance has completed or already failed.
swuferhong
force-pushed
the
reblance-api
branch
from
4f69637 to
9ddb717
Compare
|
@wuchong comments addressed. |
3 participants
Purpose
Linked issue: #1371
This pr is aims to introduce new rebalance API. For more details, please refer to https://cwiki.apache.org/confluence/display/FLUSS/FIP-8%3A+Support+Cluster+Reblance
Brief change log
Tests
API and Format
Documentation