[build] Add support for jdk17 and jdk21 and add these jdks to CI #1836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snuyanzin
changed the title
snuyanzin
commented
Oct 19, 2025
Comment on lines
+57
to
+69
| java-version: "11" | ||
|
|
||
| build-on-jdk17: | ||
| name: "Java 17" | ||
| uses: ./.github/workflows/ci-template.yaml | ||
| with: | ||
| java-version: "17" | ||
|
|
||
| build-on-jdk21: | ||
| name: "Java 21" | ||
| uses: ./.github/workflows/ci-template.yaml | ||
| with: | ||
| java-version: "21" |
Contributor
Author
There was a problem hiding this comment.
or test only on one jdk, and only build for others?
Tests for every jdk may be move to nightly?
snuyanzin
force-pushed
the
jdk17_1
branch
3 times, most recently
from
16c1ecc to
e70ca0b
Compare
Contributor
Author
|
fyi: @wuchong |
Signed-off-by: Sergey Nuyanzin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE:This PR is based on PR [hotfix][tests] Fix unstable test IcebergRecordReaderTest#testReadLogTable
I can rebase it once the first one is mergedPurpose
Add support for jdk17, 21 and also add them to ci in order to be sure it is able to build and pass tests
Brief change log
1.25.0 - first googleJavaFormat where jdk11 was dropped (for more details https://github.com/google/google-java-format/releases?page=1)
2.xx.x - jdk11 is still supported
3.0.0 is the first where jdk11 was dropped (for more details https://github.com/diffplug/spotless/releases?page=1)
skip.on.java8will not help (not sure, may be completely remove this property?)add-exportsTests
existing + with newer jdks
API and Format
no
Documentation
no