Aggregate fluss client connection metrics. #1896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loserwang1024
requested review from
swuferhong and
wuchong
and removed request for
wuchong
loserwang1024
force-pushed
the
fix-client-metrics
branch
from
7212125 to
ddb18a7
Compare
wuchong
approved these changes
Nov 4, 2025
Member
wuchong
left a comment
wuchong
left a comment
There was a problem hiding this comment.
I appended a commit to improve the implementation a bit, please take a look @loserwang1024
- Make
ConnectionMetricGroupnot extendAbstractMetricGroupto simplify the logic ofConnectionMetricGroup - Rename
ConnectionMetricGrouptoConnectionMetricsas it is not a MetricGroup now. - Remove the unused metric names in
MetricNames. - Unregister itself from
ClientMetricGroupwhen callingConnectionMetrics - Change the
Set<ConnectionMetricGroup>inClientMetricGroupinto a concurrent HashMap for thread-safe as connections will be created in multi-threads. And we should deduplicate the connections by serverId to avoid memory leak.
Contributor
Author
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #1895
Before:
After:
Brief change log
Tests
API and Format
Documentation