[lake] Support auto snapshot expiration for paimon lake table #2184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiebingYu
force-pushed
the
paimon-expire-snapshot
branch
from
949a29b to
22a0e69
Compare
LiebingYu
changed the title
LiebingYu
force-pushed
the
paimon-expire-snapshot
branch
8 times, most recently
from
5e99f29 to
4108c7c
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds support for automatic snapshot expiration for lake tables in Fluss. The feature allows snapshots to be automatically expired when the tiering service commits data to the datalake, helping to manage storage costs and maintain cleaner snapshot histories.
- Introduces two new configuration options:
table.datalake.auto-expire-snapshot(table-level) andlake.tiering.auto-expire-snapshot(tiering service-level) - Updates the
CommitterInitContextinterface to provide table info and lake tiering configuration to committers - Modifies Paimon implementation to control the
WRITE_ONLYoption based on auto-expiration settings, enabling snapshot expiration when needed
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
website/docs/maintenance/tiered-storage/lakehouse-storage.md |
Adds documentation for the new lake.tiering.auto-expire-snapshot configuration option |
website/docs/engine-flink/options.md |
Adds documentation for the new table.datalake.auto-expire-snapshot table-level option |
fluss-common/src/main/java/org/apache/fluss/config/ConfigOptions.java |
Defines the two new configuration options for snapshot expiration |
fluss-common/src/main/java/org/apache/fluss/config/TableConfig.java |
Adds accessor method for the table-level auto-expire-snapshot setting |
fluss-common/src/main/java/org/apache/fluss/lake/committer/CommitterInitContext.java |
Extends interface to include table info and lake tiering config |
fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/tiering/committer/TieringCommitterInitContext.java |
Implements the extended CommitterInitContext interface |
fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/tiering/committer/TieringCommitOperator.java |
Passes lake tiering config and table info to committer initialization |
fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/tiering/committer/TieringCommitOperatorFactory.java |
Accepts and passes through lake tiering configuration |
fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/tiering/LakeTieringJobBuilder.java |
Adds lake tiering configuration parameter to job builder |
fluss-flink/fluss-flink-tiering/src/main/java/org/apache/fluss/flink/tiering/FlussLakeTieringEntrypoint.java |
Extracts lake tiering config from command-line parameters |
fluss-lake/fluss-lake-paimon/src/main/java/org/apache/fluss/lake/paimon/tiering/PaimonLakeCommitter.java |
Updates to use TableCommitImpl and conditionally enable snapshot expiration based on config |
fluss-lake/fluss-lake-paimon/src/main/java/org/apache/fluss/lake/paimon/tiering/PaimonLakeTieringFactory.java |
Passes full CommitterInitContext to committer instead of just table path |
fluss-lake/fluss-lake-paimon/src/test/java/org/apache/fluss/lake/paimon/tiering/PaimonTieringTest.java |
Adds comprehensive tests for snapshot expiration with various configuration combinations |
fluss-lake/fluss-lake-iceberg/src/test/java/org/apache/fluss/lake/iceberg/tiering/IcebergTieringTest.java |
Updates test to use new CommitterInitContext interface |
fluss-lake/fluss-lake-lance/src/test/java/org/apache/fluss/lake/lance/tiering/LanceTieringTest.java |
Updates test to use new CommitterInitContext interface |
fluss-test-coverage/pom.xml |
Excludes TieringCommitterInitContext from coverage requirements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| public class FlussLakeTieringEntrypoint { | ||
|
|
||
| private static final String FLUSS_CONF_PREFIX = "fluss."; | ||
| private static final String LAKE_TIERING_CONFIG_PREFIX = "lake.teiring."; |
There was a problem hiding this comment.
Typo in the word "tiering": the prefix is misspelled as "lake.teiring." but should be "lake.tiering." to match the actual config option key defined in ConfigOptions.LAKE_TIERING_AUTO_EXPIRE_SNAPSHOT.
Suggested change
| private static final String LAKE_TIERING_CONFIG_PREFIX = "lake.teiring."; | |
| private static final String LAKE_TIERING_CONFIG_PREFIX = "lake.tiering."; |
luoyuxia
changed the title
luoyuxia
reviewed
Dec 19, 2025
Contributor
luoyuxia
left a comment
luoyuxia
left a comment
There was a problem hiding this comment.
@LiebingYu Thanks for the pr. Left minor comments. Otherwise, LGTM
Btw, coud you please create a issue for iceberg to respect the snapshot expiration option?
| public class FlussLakeTieringEntrypoint { | ||
|
|
||
| private static final String FLUSS_CONF_PREFIX = "fluss."; | ||
| private static final String LAKE_TIERING_CONFIG_PREFIX = "lake.teiring."; |
LiebingYu
force-pushed
the
paimon-expire-snapshot
branch
from
4108c7c to
6d72ff6
Compare
2 tasks
Contributor
Author
Sure, created at #2213. |
LiebingYu
force-pushed
the
paimon-expire-snapshot
branch
from
6d72ff6 to
3884be2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #2182
Brief change log
Tests
API and Format
Documentation