Fluss support ACL authotization #588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@wuchong , CC |
loserwang1024
force-pushed
the
fluss-acl-api
branch
4 times, most recently
from
7767d13 to
ca714de
Compare
loserwang1024
force-pushed
the
fluss-acl-api
branch
from
ca714de to
c05bca0
Compare
loserwang1024
changed the title
2 tasks
wuchong
reviewed
Apr 17, 2025
Member
wuchong
left a comment
wuchong
left a comment
There was a problem hiding this comment.
- Let's add
FlinkAuthorizationITCasefor general read/write/create/drop operations on the tables. - We can remove IDEMPOTENT_WRITE operation type in this PR, to just not check permission for it, and supports authorization for it in the next PR #756
- I created #757 to update the implementation of ServerMetadataCache instead of relying on
notifyLeaderRPC
fluss-client/src/main/java/com/alibaba/fluss/client/admin/DeleteAclsResult.java
Show resolved
Hide resolved
fluss-client/src/main/java/com/alibaba/fluss/client/admin/DeleteAclsResult.java
Outdated
Show resolved
Hide resolved
fluss-client/src/main/java/com/alibaba/fluss/client/admin/DeleteAclsResult.java
Outdated
Show resolved
Hide resolved
fluss-client/src/main/java/com/alibaba/fluss/client/admin/CreateAclsResult.java
Outdated
Show resolved
Hide resolved
fluss-client/src/main/java/com/alibaba/fluss/client/admin/DeleteAclsResult.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/com/alibaba/fluss/server/coordinator/CoordinatorServer.java
Show resolved
Hide resolved
fluss-server/src/main/java/com/alibaba/fluss/server/tablet/TabletServer.java
Show resolved
Hide resolved
| if (authorizer != null) { | ||
| authorizer.authorize( | ||
| currentSession(), | ||
| OperationType.CREATE, |
Member
There was a problem hiding this comment.
For partitions, I think we should use WRITE permission under the table. That means if a user has the write permission of a table, then he can create partitions. Otherwise, he has to apply CREATE/DROP permission which is very hard to use. Partition is just an internal data distribution.
Add IT case for this in FlinkAuthorizationITCase
fluss-server/src/main/java/com/alibaba/fluss/server/coordinator/CoordinatorService.java
Outdated
Show resolved
Hide resolved
| public CompletableFuture<FetchLogResponse> fetchLog(FetchLogRequest request) { | ||
| CompletableFuture<FetchLogResponse> response = new CompletableFuture<>(); | ||
| Map<TableBucket, FetchData> fetchLogData = getFetchLogData(request); | ||
| for (TableBucket tableBucket : fetchLogData.keySet()) { |
…luster to database
loserwang1024
force-pushed
the
fluss-acl-api
branch
from
eaca8a1 to
4a13fd0
Compare
…lient when reading.
loserwang1024
force-pushed
the
fluss-acl-api
branch
5 times, most recently
from
9151836 to
af35430
Compare
loserwang1024
force-pushed
the
fluss-acl-api
branch
from
af35430 to
4dedc9e
Compare
wuchong
approved these changes
Apr 24, 2025
Member
wuchong
left a comment
wuchong
left a comment
There was a problem hiding this comment.
Looks good to me in general. I left some minor comments and pushed a commit the address them. Please take a look at that changes.
fluss-client/src/main/java/com/alibaba/fluss/client/table/scanner/log/LogFetcher.java
Outdated
Show resolved
Hide resolved
...link-common/src/test/java/com/alibaba/fluss/flink/security/acl/FlinkAuthorizationITCase.java
Outdated
Show resolved
Hide resolved
fluss-rpc/src/main/java/com/alibaba/fluss/rpc/entity/FetchLogResultForBucket.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/com/alibaba/fluss/server/authorizer/DefaultAuthorizer.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/com/alibaba/fluss/server/tablet/TabletService.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/com/alibaba/fluss/server/tablet/TabletService.java
Show resolved
Hide resolved
fluss-server/src/main/java/com/alibaba/fluss/server/tablet/TabletService.java
Show resolved
Hide resolved
fluss-server/src/main/java/com/alibaba/fluss/server/utils/ServerRpcMessageUtils.java
Outdated
Show resolved
Hide resolved
fluss-server/src/test/java/com/alibaba/fluss/server/authorizer/DefaultAuthorizerTest.java
Outdated
Show resolved
Hide resolved
2 tasks
Contributor
Author
LGTM |
polyzos
pushed a commit
to polyzos/fluss
that referenced
this pull request
Apr 27, 2025
Co-authored-by: Jark Wu <[email protected]>
ZmmBigdata
pushed a commit
to ZmmBigdata/fluss
that referenced
this pull request
Jun 20, 2025
Co-authored-by: Jark Wu <[email protected]>
polyzos
pushed a commit
to polyzos/fluss
that referenced
this pull request
Aug 30, 2025
Co-authored-by: Jark Wu <[email protected]>
polyzos
pushed a commit
to Alibaba-HZY/fluss
that referenced
this pull request
Aug 31, 2025
Co-authored-by: Jark Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #485
This pr includes three things:
Test