Skip to content

[#10529] improvement(all): upgrade Jetty to 9.4.58 and exclude unused Jetty from hive-metastore3-libs#10532

Open
geyanggang wants to merge 2 commits intoapache:mainfrom
geyanggang:upgrade-eclipse-jetty-version
Open

[#10529] improvement(all): upgrade Jetty to 9.4.58 and exclude unused Jetty from hive-metastore3-libs#10532
geyanggang wants to merge 2 commits intoapache:mainfrom
geyanggang:upgrade-eclipse-jetty-version

Conversation

@geyanggang
Copy link
Contributor

What changes were proposed in this pull request?

  1. Updated jetty version from 9.4.51.v20230217 to 9.4.58.v20250814 in libs.versions.toml.
  2. Added exclude("org.eclipse.jetty") to both hadoop2-common and hive3-metastore dependencies in build.gradle.kts.

Why are the changes needed?

  1. The Jetty version upgrade brings the latest patches for modules that directly use Jetty (iceberg-rest-server, lance-rest-server).
  2. In hive-metastore3-libs, Jetty 9.3.20 is a transitive dependency from hadoop-common:3.1.0 (pulled in via hive3-metastore). Due to HiveClientClassLoader's classloader isolation, Hadoop classes are loaded from the base classloader which already has no Jetty, making these Jetty jars dead code. Both hadoop2-common and hive3-metastore need the exclude because Gradle resolves hadoop-common 2.10.2 → 3.1.0 (higher version wins), creating two dependency paths to Jetty.

Fix: #10529

Does this PR introduce any user-facing change?

No.

How was this patch tested?

  1. Verified compileJava, jar, and test pass for :catalogs:catalog-hive and :catalogs:hive-metastore3-libs
  2. Confirmed Jetty no longer appears in hive-metastore3-libs runtimeClasspath dependency tree

@geyanggang geyanggang force-pushed the upgrade-eclipse-jetty-version branch from 5f159f7 to 4426a1b Compare March 24, 2026 11:14
@github-actions
Copy link

github-actions bot commented Mar 25, 2026

Code Coverage Report

Overall Project 64.89% 🟢
Files changed No Java source files changed -

Module Coverage
aliyun 1.73% 🔴
api 47.14% 🟢
authorization-common 85.96% 🟢
aws 1.1% 🔴
azure 2.6% 🔴
catalog-common 10.0% 🔴
catalog-fileset 80.02% 🟢
catalog-hive 80.98% 🟢
catalog-jdbc-clickhouse 79.06% 🟢
catalog-jdbc-common 42.89% 🟢
catalog-jdbc-doris 80.28% 🟢
catalog-jdbc-hologres 54.03% 🟢
catalog-jdbc-mysql 79.23% 🟢
catalog-jdbc-oceanbase 78.38% 🟢
catalog-jdbc-postgresql 82.05% 🟢
catalog-jdbc-starrocks 78.27% 🟢
catalog-kafka 77.01% 🟢
catalog-lakehouse-generic 45.07% 🟢
catalog-lakehouse-hudi 79.1% 🟢
catalog-lakehouse-iceberg 87.15% 🟢
catalog-lakehouse-paimon 77.71% 🟢
catalog-model 77.72% 🟢
cli 44.51% 🟢
client-java 77.83% 🟢
common 49.42% 🟢
core 80.9% 🟢
filesystem-hadoop3 76.97% 🟢
flink 38.86% 🔴
flink-runtime 0.0% 🔴
gcp 14.2% 🔴
hadoop-common 10.39% 🔴
hive-metastore-common 45.82% 🟢
iceberg-common 50.21% 🟢
iceberg-rest-server 66.51% 🟢
integration-test-common 0.0% 🔴
jobs 66.17% 🟢
lance-common 23.88% 🔴
lance-rest-server 57.84% 🟢
lineage 53.02% 🟢
optimizer 82.95% 🟢
optimizer-api 21.95% 🔴
server 85.62% 🟢
server-common 70.14% 🟢
spark 32.79% 🔴
spark-common 39.09% 🔴
trino-connector 31.62% 🔴

@yuqi1129 yuqi1129 requested a review from diqiu50 March 25, 2026 09:47
@yuqi1129
Copy link
Contributor

@diqiu50

Can you also take a look? I have no more comments.

@geyanggang geyanggang force-pushed the upgrade-eclipse-jetty-version branch from 4426a1b to db1e5ef Compare March 26, 2026 04:15
@geyanggang geyanggang requested a review from diqiu50 March 26, 2026 06:49
@geyanggang geyanggang requested review from diqiu50 March 26, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement] Upgrade Jetty to 9.4.58 and exclude unused Jetty from hive-metastore3-libs

3 participants