-
Notifications
You must be signed in to change notification settings - Fork 811
[#10862] improvement(ci): Pre-install JDK 24 to stabilize Trino connector build #10863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
88e0246
63247b5
78eac3c
504d91f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| name: 'Setup Java Toolchains' | ||
| description: 'Install a primary JDK and JDK 24 (for Trino), register JDK 24 with Gradle toolchain' | ||
|
|
||
| inputs: | ||
| java-version: | ||
| description: 'Primary Java version' | ||
| default: '17' | ||
| cache: | ||
| description: 'Gradle cache setting' | ||
| default: 'gradle' | ||
|
|
||
| runs: | ||
| using: composite | ||
| steps: | ||
| - uses: actions/setup-java@v4 | ||
| id: setup-jdk24 | ||
| with: | ||
| java-version: 24 | ||
| distribution: temurin | ||
|
|
||
| - uses: actions/setup-java@v4 | ||
| with: | ||
| java-version: ${{ inputs.java-version }} | ||
| distribution: temurin | ||
| cache: ${{ inputs.cache }} | ||
|
|
||
| - name: Register JDK 24 with Gradle toolchain | ||
| shell: bash | ||
| run: | | ||
| mkdir -p ~/.gradle | ||
| echo "org.gradle.java.installations.paths=${{ steps.setup-jdk24.outputs.path }}" >> ~/.gradle/gradle.properties | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -69,16 +69,20 @@ include("iceberg:iceberg-rest-server") | |
| include("lance:lance-common") | ||
| include("lance:lance-rest-server") | ||
| include("authorizations:authorization-ranger", "authorizations:authorization-common", "authorizations:authorization-chain") | ||
| include( | ||
| "trino-connector:trino-connector", | ||
| "trino-connector:trino-connector-435-439", | ||
| "trino-connector:trino-connector-440-445", | ||
| "trino-connector:trino-connector-446-451", | ||
| "trino-connector:trino-connector-452-468", | ||
| "trino-connector:trino-connector-469-472", | ||
| "trino-connector:trino-connector-473-478", | ||
| "trino-connector:integration-test" | ||
| ) | ||
| if (gradle.startParameter.projectProperties["skipTrinoConnector"]?.toBoolean() != true) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's the default value of it?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need to set this to true in the backend CI pipeline?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. false |
||
| include( | ||
| "trino-connector:trino-connector", | ||
| "trino-connector:trino-connector-435-439", | ||
| "trino-connector:trino-connector-440-445", | ||
| "trino-connector:trino-connector-446-451", | ||
| "trino-connector:trino-connector-452-468", | ||
| "trino-connector:trino-connector-469-472", | ||
| "trino-connector:trino-connector-473-478", | ||
| "trino-connector:integration-test" | ||
| ) | ||
| } else { | ||
| println("Skipping trino-connector modules since skipTrinoConnector is set to true") | ||
| } | ||
| include("spark-connector:spark-common") | ||
| if (scalaVersion == "2.12") { | ||
| // flink only support scala 2.12 | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.