HBASE-29363: CompactSplit should not attempt to split secondary region replicas #7048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesconnell
commented
May 29, 2025
| if (server.getNumberOfOnlineRegions() > 0.9 * regionSplitLimit) { | ||
| LOG.warn("Total number of regions is approaching the upper limit " + regionSplitLimit + ". " | ||
| + "Please consider taking a look at http://hbase.apache.org/book.html#ops.regionmgt"); | ||
| } | ||
| return (regionSplitLimit > server.getNumberOfOnlineRegions()); | ||
| return (regionSplitLimit > server.getNumberOfOnlineRegions() | ||
| && ri.getReplicaId() == RegionInfo.DEFAULT_REPLICA_ID); |
There was a problem hiding this comment.
This is the key change, every other part of this PR is just unit testing
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull Request Overview
This PR addresses HBASE-29363 by ensuring that secondary region replicas are not split during compaction procedures. Key changes include:
- Changing test lifecycle annotations to use instance-level setup/cleanup.
- Adding a new test case to verify that only primary replicas are split.
- Modifying the splitting logic in CompactSplit to check the region’s replica ID and increment a test counter.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactSplitThread.java | Updated test lifecycle annotations and added testFlushWithRegionReplicas for replica-specific split behavior. |
| hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java | Refactored shouldSplitRegion to conditionally split only primary replicas and exposed a split counter for testing. |
Comments suppressed due to low confidence (1)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactSplitThread.java:66
- Changing from class-level (@BeforeClass/@afterclass) to instance-level (@Before/@after) setup may slow down test execution by reinitializing the mini cluster for every test. If test isolation is not critical, consider reverting to class-level initialization to improve performance.
@Before
| if (server.getNumberOfOnlineRegions() > 0.9 * regionSplitLimit) { | ||
| LOG.warn("Total number of regions is approaching the upper limit " + regionSplitLimit + ". " | ||
| + "Please consider taking a look at http://hbase.apache.org/book.html#ops.regionmgt"); | ||
| } | ||
| return (regionSplitLimit > server.getNumberOfOnlineRegions()); | ||
| return (regionSplitLimit > server.getNumberOfOnlineRegions() | ||
| && ri.getReplicaId() == RegionInfo.DEFAULT_REPLICA_ID); |
There was a problem hiding this comment.
[nitpick] Since this condition ensures that only primary replicas are allowed to be split, consider adding a brief code comment or updating the documentation to clarify this behavior for future maintainers.
Copilot uses AI. Check for mistakes.
Apache9
reviewed
Jun 1, 2025
| @@ -90,6 +91,8 @@ public class CompactSplit implements CompactionRequester, PropagatingConfigurati | |||
| private volatile ThreadPoolExecutor longCompactions; | |||
| private volatile ThreadPoolExecutor shortCompactions; | |||
| private volatile ThreadPoolExecutor splits; | |||
| // Used in unit testing | |||
| private int splitCounter; | |||
There was a problem hiding this comment.
Is it possible to not introduce field in normal code which is only used for testing?
Apache9
approved these changes
Jun 2, 2025
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
pushed a commit
that referenced
this pull request
Jun 3, 2025
… replicas (#7048) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit ae5400e)
Apache9
pushed a commit
that referenced
this pull request
Jun 3, 2025
… replicas (#7048) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit ae5400e)
Apache9
pushed a commit
that referenced
this pull request
Jun 3, 2025
… replicas (#7048) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit ae5400e)
Apache9
pushed a commit
that referenced
this pull request
Jun 3, 2025
… replicas (#7048) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit ae5400e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.