HBASE-30304 Prevent Bytes.toBytesBinary from throwing on truncated \x escape - #8508
Merged
Conversation
… escape The \xNN parser guards only that the 'x' after a backslash exists, then reads the two hex digits at i+2 and i+3 unconditionally. A string ending in "\x" or "\x0" throws. Widen the guard to require both hex digits in bounds. A truncated tail escape now falls through to the existing bogus-escape path and emits the backslash literally. HBASE-6518 fixed the trailing bare-backslash case with the same guard but did not extend it to the hex digits.
liuxiaocs7
approved these changes
Jul 27, 2026
Member
Author
|
@liuxiaocs7 Thanks for the review! |
junegunn
added a commit
that referenced
this pull request
Jul 30, 2026
… escape (#8508) The \xNN parser guards only that the 'x' after a backslash exists, then reads the two hex digits at i+2 and i+3 unconditionally. A string ending in "\x" or "\x0" throws. Widen the guard to require both hex digits in bounds. A truncated tail escape now falls through to the existing bogus-escape path and emits the backslash literally. HBASE-6518 fixed the trailing bare-backslash case with the same guard but did not extend it to the hex digits. Signed-off-by: Xiao Liu <liuxiaocs@apache.org>
junegunn
added a commit
that referenced
this pull request
Jul 30, 2026
… escape (#8508) The \xNN parser guards only that the 'x' after a backslash exists, then reads the two hex digits at i+2 and i+3 unconditionally. A string ending in "\x" or "\x0" throws. Widen the guard to require both hex digits in bounds. A truncated tail escape now falls through to the existing bogus-escape path and emits the backslash literally. HBASE-6518 fixed the trailing bare-backslash case with the same guard but did not extend it to the hex digits. Signed-off-by: Xiao Liu <liuxiaocs@apache.org>
junegunn
added a commit
that referenced
this pull request
Jul 30, 2026
… escape (#8508) The \xNN parser guards only that the 'x' after a backslash exists, then reads the two hex digits at i+2 and i+3 unconditionally. A string ending in "\x" or "\x0" throws. Widen the guard to require both hex digits in bounds. A truncated tail escape now falls through to the existing bogus-escape path and emits the backslash literally. HBASE-6518 fixed the trailing bare-backslash case with the same guard but did not extend it to the hex digits. Signed-off-by: Xiao Liu <liuxiaocs@apache.org>
junegunn
added a commit
that referenced
this pull request
Jul 30, 2026
… escape (#8508) The \xNN parser guards only that the 'x' after a backslash exists, then reads the two hex digits at i+2 and i+3 unconditionally. A string ending in "\x" or "\x0" throws. Widen the guard to require both hex digits in bounds. A truncated tail escape now falls through to the existing bogus-escape path and emits the backslash literally. HBASE-6518 fixed the trailing bare-backslash case with the same guard but did not extend it to the hex digits. Signed-off-by: Xiao Liu <liuxiaocs@apache.org>
junegunn
added a commit
that referenced
this pull request
Jul 30, 2026
… escape (#8508) The \xNN parser guards only that the 'x' after a backslash exists, then reads the two hex digits at i+2 and i+3 unconditionally. A string ending in "\x" or "\x0" throws. Widen the guard to require both hex digits in bounds. A truncated tail escape now falls through to the existing bogus-escape path and emits the backslash literally. HBASE-6518 fixed the trailing bare-backslash case with the same guard but did not extend it to the hex digits. Signed-off-by: Xiao Liu <liuxiaocs@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/HBASE-30304