Skip to content

HBASE-30304 Prevent Bytes.toBytesBinary from throwing on truncated \x escape #8508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
junegunn merged 1 commit into from
Jul 30, 2026
+4 −2
Merged

HBASE-30304 Prevent Bytes.toBytesBinary from throwing on truncated \x escape #8508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,7 +610,7 @@ public static byte[] toBytesBinary(String in) {
int size = 0;
for (int i = 0; i < in.length(); ++i) {
char ch = in.charAt(i);
if (ch == '\\' && in.length() > i + 1 && in.charAt(i + 1) == 'x') {
if (ch == '\\' && in.length() > i + 3 && in.charAt(i + 1) == 'x') {
// ok, take next 2 hex digits.
char hd1 = in.charAt(i + 2);
char hd2 = in.charAt(i + 3);
Expand Down
4 changes: 3 additions & 1 deletion hbase-common/src/test/java/org/apache/hadoop/hbase/util/BytesTestBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,9 +423,11 @@ public void testCopy() {
}

@Test
public void testToBytesBinaryTrailingBackslashes() {
public void testToBytesBinaryTruncatedHexDigit() {
try {
Bytes.toBytesBinary("abc\\x00\\x01\\");
Bytes.toBytesBinary("abc\\x00\\x01\\x");
Bytes.toBytesBinary("abc\\x00\\x01\\x0");
} catch (StringIndexOutOfBoundsException ex) {
fail("Illegal string access: " + ex.getMessage());
}
Expand Down