CORE: Inject OAuth2 Token from TableSession

[wolflex888]

Originally, we are expecting loadTable from the REST Service to return token as part of the config in LoadTableResponse. The token should have access to the table the application is interacting with.

In this PR, I am proposing to inject the token from tableSession that's created within RestSessionCatalog.loadTable. This make sense since RestSessionCatalog already make a request to the REST service for a token that is dedicated to interact with the table. We can use it to interact with the server instead of getting another one from the endpoint.

[nastra]

I don't think I fully follow why this change is needed. If a REST server supports a sub-scoped table token, then the server would return this via the token field in LoadTableResponse#config and so you would end up having a properly configured tableSession (which already takes in the tableConf with the potentially sub-scoped table token).

[wolflex888]

Since we are already getting a tableSession that's dedicated to interact with the table from the REST server. will it make more sense to pass it down to VendedCredentialsProvider instead of expecting LoadTableResponse.config() to include that property? This is just a proposal, I'm still trying to figure out how iceberg should interact with a REST server, Apache Polaris in our case.

[nastra]

Since we are already getting a tableSession that's dedicated to interact with the table from the REST server. will it make more sense to pass it down to VendedCredentialsProvider instead of expecting LoadTableResponse.config() to include that property?

this is already being done today in

iceberg/aws/src/main/java/org/apache/iceberg/aws/AwsClientProperties.java

Lines 203 to 206 in 7d0395d

	Optional.ofNullable(allProperties.get(OAuth2Properties.TOKEN))
	.ifPresent(
	token ->
	clientCredentialsProviderProperties.putIfAbsent(OAuth2Properties.TOKEN, token));

[wolflex888]

right. but when loadTable is called, the token from the tableSession does not get included in the property that initiates tableFileIO. This PR is proposing to include that token in the properties so the VendedCredentialsProvider can use it to initiate the http client.

[nastra]

@wolflex888 I'm not sure I'm following here. The oauth token that is potentially sub-scoped to the loaded table is passed to the Table FileIO instance in https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java#L973-L980

[github-actions]

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

[github-actions]

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.