support ipv6 #786
Open
support ipv6 #786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxfeng1997
commented
Mar 8, 2025
| ) | ||
|
|
||
| // Analyze it yourself here, in order to support the diversity of configurations | ||
| func SplitIPPortStr(addr string) (string, int, error) { |
There was a problem hiding this comment.
seata使用的第三方库本身也对IPv6有支持，不过对于不带 “[]” 括号的ipv6解析不对且对于%符号也需要另外处理，dubbo-go代码上看也是这样。但是查看java版本的seata代码也是自己解析且支持不带“[]”括号以及%符号处理的，所以这里自己加了这个地址工具。
Code-Fight
requested changes
Mar 14, 2025
|
测试下，能否跑通整个流程 |
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This pr will support ipv6
Which issue(s) this PR fixes:
#710
Special notes for your reviewer:
Does this PR introduce a user-facing change?: