-
Notifications
You must be signed in to change notification settings - Fork 303
support ipv6 #786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
support ipv6 #786
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
98eeabf
support ipv6
lxfeng1997 324f255
add license
lxfeng1997 e18a09b
Merge branch 'master' into support_ipv6
luky116 5f854dd
Merge branch 'master' into support_ipv6
luky116 4246d92
support ipv6
lxfeng1997 ef0c191
support ipv6
lxfeng1997 65a515a
Merge branch 'master' into support_ipv6
luky116 cd06d6a
Merge branch 'master' into support_ipv6
Code-Fight File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package net | ||
|
||
import ( | ||
"fmt" | ||
"regexp" | ||
"strconv" | ||
"strings" | ||
) | ||
|
||
const ( | ||
addressSplitChar = ":" | ||
) | ||
|
||
func SplitIPPortStr(addr string) (string, int, error) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. seata使用的第三方库本身也对IPv6有支持,不过对于不带 “[]” 括号的ipv6解析不对且对于%符号也需要另外处理,dubbo-go代码上看也是这样。但是查看java版本的seata代码也是自己解析且支持不带“[]”括号以及%符号处理的,所以这里自己加了这个地址工具。 |
||
if addr == "" { | ||
return "", 0, fmt.Errorf("split ip err: param addr must not empty") | ||
} | ||
|
||
if addr[0] == '[' { | ||
reg := regexp.MustCompile("[\\[\\]]") | ||
addr = reg.ReplaceAllString(addr, "") | ||
} | ||
|
||
i := strings.LastIndex(addr, addressSplitChar) | ||
if i < 0 { | ||
return "", 0, fmt.Errorf("address %s: missing port in address", addr) | ||
} | ||
|
||
host := addr[:i] | ||
port := addr[i+1:] | ||
|
||
if strings.Contains(host, "%") { | ||
reg := regexp.MustCompile("\\%[0-9]+") | ||
host = reg.ReplaceAllString(host, "") | ||
} | ||
|
||
portInt, err := strconv.Atoi(port) | ||
if err != nil { | ||
return "", 0, err | ||
} | ||
return host, portInt, nil | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.