-
Notifications
You must be signed in to change notification settings - Fork 14.8k
KAFKA-16263 : Add Kafka Streams docs about available listeners/callback #20589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
| <div class="pagination"> | ||
| <ul> | ||
| <li> | ||
| <b>UncaughtExceptionHandler</b><br/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <b>UncaughtExceptionHandler</b><br/> | |
| <b>StreamsUncaughtExceptionHandler:</b><br/> |
| </li> | ||
|
|
||
| <li> | ||
| <b>State Listener</b><br/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <b>State Listener</b><br/> | |
| <b>State Listener:</b><br/> |
| </li> | ||
|
|
||
| <li> | ||
| <b>Global State Restore Listener</b><br/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <b>Global State Restore Listener</b><br/> | |
| <b>Global State Restore Listener:</b><br/> |
| </li> | ||
|
|
||
| <li> | ||
| <b>ProductionExceptionHandler</b> and <b>DeserializationExceptionHandler</b><br/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <b>ProductionExceptionHandler</b> and <b>DeserializationExceptionHandler</b><br/> | |
| <b>ProductionExceptionHandler</b> and <b>DeserializationExceptionHandler</b>:<br/> |
| </li> | ||
|
|
||
| <li> | ||
| <b>ConsumerRebalanceListener</b><br/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is not supported by Kafka Streams, but only by the KafkaConsumer, as the text actually says. Don't think it belongs into the KS part of the docs.
|
|
||
| <pre> | ||
| <code class="language-java"> | ||
| // Handle uncaught exceptions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| // Handle uncaught exceptions | |
| // Handle uncaught exceptions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This applies to all lines of the code example. To avoid weird formatting, we need to remove all these trailing spaces, otherwise they are rendered in the docs, and instead of this:
Example usage of exception and state restore listeners:
// Handle uncaught exceptions ...
we would get
Example usage of exception and state restore listeners:
// Handle uncaught exceptions ...
What is rather weird.
|
Hi @samarth-ksolves, are you still working on this? I am working on something similar in #21000, and think your changes would be a good addition. |
This PR updated the running-app.html to:
it hard for developers (especially beginners) to use them.
listeners/callbacks like uncaught-exception-handler,
state-restore-listener, state-listener, etc.
listener/callback.