MINOR: Various small cleanups in group-coordinator#21450
Merged
mimaison merged 3 commits intoapache:trunkfrom Feb 12, 2026
Merged
MINOR: Various small cleanups in group-coordinator#21450mimaison merged 3 commits intoapache:trunkfrom
mimaison merged 3 commits intoapache:trunkfrom
Conversation
dajac
reviewed
Feb 11, 2026
Comment on lines
7760
to
7761
| List.of(), | ||
| new HeartbeatResponseData().setErrorCode(Errors.REBALANCE_IN_PROGRESS.code()) |
dajac
reviewed
Feb 11, 2026
Comment on lines
7770
to
7771
| List.of(), | ||
| new HeartbeatResponseData() |
dajac
reviewed
Feb 11, 2026
Comment on lines
7754
to
7755
| List.of(), | ||
| new HeartbeatResponseData().setErrorCode(Errors.UNKNOWN_MEMBER_ID.code()) |
Member
Author
|
Thanks @dajac for the review. I push an update. |
chia7712
reviewed
Feb 12, 2026
| @@ -199,7 +199,7 @@ public static Set<String> configNames() { | |||
| */ | |||
| public static void validateNames(Properties props) { | |||
Member
There was a problem hiding this comment.
Consider refactoring the call path to use Map instead. I didn't see the specific benefit of using Properties here
Member
There was a problem hiding this comment.
we can address that in a follow-up
Member
Author
There was a problem hiding this comment.
If we want to do that change let's do it in a separate PR. The caller path comes all the way from ControllerConfigurationValidator which uses Properties for all resource types.
| log.warn("Cannot downgrade the consumer group " + consumerGroup.groupId() + ": fail to parse " + | ||
| "the Consumer Protocol " + ConsumerProtocol.PROTOCOL_TYPE + ".", e); | ||
| log.warn("Cannot downgrade the consumer group {}: fail to parse the Consumer Protocol {}.", | ||
| consumerGroup.groupId(), ConsumerProtocol.PROTOCOL_TYPE, e); |
Member
There was a problem hiding this comment.
Please remove the unnecessary indent
| " to consumer group because the embedded consumer protocol is malformed: " | ||
| + e.getMessage() + ".", e); | ||
| log.warn("Cannot upgrade classic group {} to consumer group because the embedded consumer protocol is malformed: {}.", | ||
| classicGroup.groupId(), e.getMessage(), e); |
chia7712
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewers: David Jacot djacot@confluent.io, Chia-Ping Tsai
chia7712@gmail.com