Skip to content

arch/stm32f0l0g0: add watchdog support #16150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025

Conversation

raiden00pl
Copy link
Member

Summary

  • arch/stm32f0l0g0: add support for IWDG and WWDG
  • boards/nucleo-c071rb: add watchdog support

Impact

new features

Testing

nucleo-c071rb and b-l072z-lrwan1 with IWDG and examples/watchdog

@github-actions github-actions bot added Area: Documentation Improvements or additions to documentation Arch: arm Issues related to ARM (32-bit) architecture Board: arm Size: XL The size of the change in this PR is very large. Consider breaking down the PR into smaller pieces. labels Apr 7, 2025
add IWDG and WWDG support for stm32f0l0g0.

ported from arch/stm32.

Signed-off-by: raiden00pl <[email protected]>
boards/nucleo-c071rb: add watchdog support and enable IWDG for jumbo configuration

Signed-off-by: raiden00pl <[email protected]>
@nuttxpr
Copy link

nuttxpr commented Apr 7, 2025

[Experimental Bot, please feedback here]

No, this PR description does not fully meet the NuttX requirements. While it provides some information, it lacks crucial details in several sections. Here's a breakdown of what's missing:

Summary:

  • Missing "Why": The summary states what was changed, but not why. Was this requested by a user? Does it fix a bug? Is it part of a larger feature implementation?
  • Missing "How": It mentions adding support, but doesn't explain how it works. Did it involve new drivers? Modifications to existing code? What specific functionality is enabled?

Impact:

  • Insufficient Detail: Simply stating "new features" is not enough. The impact section requires more detailed answers. While the impact might be minimal for some areas, explicitly stating "NO" with a brief justification is better than leaving it blank. For example:
    • User Impact: YES. Users can now utilize the IWDG and WWDG features on the nucleo-c071rb board. They will need to consult updated documentation to understand configuration and usage.
    • Build Impact: Potentially YES. If new Kconfig options were added, the build configuration process might be affected. Specify any changes to dependencies or configuration options.
    • Hardware Impact: YES. This specifically affects the stm32f0l0g0 architecture and the nucleo-c071rb board. Mention any changes to pin assignments or resource usage.
    • Documentation Impact: YES. Documentation needs to be updated to describe the new watchdog features, their configuration, and usage examples. State whether this documentation update is included in the PR.
    • Security Impact: Potentially YES. Watchdogs are often security-related. Explain any potential security implications of this change, even if just to say "No impact on security beyond the intended watchdog functionality."
    • Compatibility Impact: Likely NO. But it's good to explicitly state this and give a brief reason (e.g., "No compatibility impact as this adds new features without modifying existing functionality.").

Testing:

  • Insufficient Host Detail: What OS, CPU architecture, and compiler version were used for building? Be specific. (e.g., "Build Host: Linux x86_64, GCC 12.2")
  • Insufficient Target Detail: Be more specific about the target configurations. (e.g., "Target: stm32f0l0g0:nucleo-c071rb and stm32l072cz:b-l072z-lrwan1")
  • Missing Logs: The testing logs sections are empty. Provide actual log output demonstrating the watchdogs functioning correctly before and after the changes. If the logs are extensive, consider linking to a separate file or using a service like pastebin.

In short, the PR description needs to be significantly expanded to meet the NuttX requirements. Provide the missing details and ensure all sections are thoroughly addressed, even if the answer is "NO." This will make the review process much smoother and increase the chances of your PR being accepted.

@xiaoxiang781216 xiaoxiang781216 merged commit b81c4d3 into apache:master Apr 7, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arch: arm Issues related to ARM (32-bit) architecture Area: Documentation Improvements or additions to documentation Board: arm Size: XL The size of the change in this PR is very large. Consider breaking down the PR into smaller pieces.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants