Open
Conversation
dosubot
bot
added
size:M
TennyZhuang
changed the title
Xuanwo
reviewed
Oct 16, 2025
| ------- | ||
| None | ||
| """ | ||
| async def delete_many(self, paths: Iterable[PathBuf]) -> None: |
Member
There was a problem hiding this comment.
Maybe we could just make delete accept this?
Contributor
Author
There was a problem hiding this comment.
I've updated it according to your suggestion, but I feel the updated code is a bit complex.
There are two ways to achieve this goal:
Use the current approach in the PR, hack the function in the Python layer to do forwarding.
Accept a generic object as a parameter in Rust, then check the PyType type in Rust and forward accordingly.
Both methods significantly impact readability and seem to introduce unnecessary complexity. If you agree, I can roll back this PR.
| None | ||
| """ | ||
| async def delete_many(self, paths: Iterable[PathBuf]) -> None: | ||
| """Delete multiple objects in a single request. |
Member
There was a problem hiding this comment.
There is no guarantee about this.
dosubot
bot
added
size:L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
The Python SDK could only delete objects one at a time, which meant callers had to loop and missed out on the batch deletion facilities exposed by the core Operator.
What changes are included in this PR?
Operator.delete_manyandAsyncOperator.delete_manywrappers over the coredelete_iterAPIAre there any user-facing changes?
Operator.delete_many/AsyncOperator.delete_manyfor batch deletions.pytest tests/test_sync_delete.py tests/test_async_delete.pywithOPENDAL_TEST=memory.