-
Notifications
You must be signed in to change notification settings - Fork 733
feat(python): add delete_many API #6679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TennyZhuang
wants to merge
3
commits into
apache:main
Choose a base branch
from
TennyZhuang:feat/python-delete-many
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -152,6 +152,18 @@ class Operator(_Base): | |
| ------- | ||
| None | ||
| """ | ||
| def delete_many(self, paths: Iterable[PathBuf]) -> None: | ||
| """Delete multiple objects in a single request. | ||
|
|
||
| Args: | ||
| paths (Iterable[str | Path]): Collection of object paths to delete. | ||
| Each element is treated the same as calling :py:meth:`delete` | ||
| individually. | ||
|
|
||
| Notes | ||
| ----- | ||
| Missing objects are ignored by default. | ||
| """ | ||
| def stat(self, path: PathBuf, **kwargs) -> Metadata: | ||
| """Get the metadata of the object at the given path. | ||
|
|
||
|
|
@@ -381,6 +393,18 @@ class AsyncOperator(_Base): | |
| ------- | ||
| None | ||
| """ | ||
| async def delete_many(self, paths: Iterable[PathBuf]) -> None: | ||
| """Delete multiple objects in a single request. | ||
|
||
|
|
||
| Args: | ||
| paths (Iterable[str | Path]): Collection of object paths to delete. | ||
| Each element is treated the same as calling :py:meth:`delete` | ||
| individually. | ||
|
|
||
| Notes | ||
| ----- | ||
| Missing objects are ignored by default. | ||
| """ | ||
| async def stat(self, path: PathBuf, **kwargs) -> Metadata: | ||
| """Get the metadata of the object at the given path. | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could just make
deleteaccept this?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated it according to your suggestion, but I feel the updated code is a bit complex.
There are two ways to achieve this goal:
Use the current approach in the PR, hack the function in the Python layer to do forwarding.
Accept a generic object as a parameter in Rust, then check the PyType type in Rust and forward accordingly.
Both methods significantly impact readability and seem to introduce unnecessary complexity. If you agree, I can roll back this PR.