fix(core): skip NotFound during concurrent recursive listing#7230
Merged
fix(core): skip NotFound during concurrent recursive listing#7230
Conversation
tisonkun
approved these changes
Feb 26, 2026
Member
tisonkun
left a comment
There was a problem hiding this comment.
Still failed. But unblock the process once you get all the CI checks pass.
Member
Author
fs is passing, other failure might be related to GHA, will retry them |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Behavior tests for
fscan fail intermittently under concurrent execution with errors like:NotFound (persistent) at list ... source: No such file or directory (os error 2)The failure happens when recursive list traverses entries that are removed by other concurrent tests. In this case, treating
NotFoundas a hard failure makes list behavior flaky.What changes are included in this PR?
FlatListerto tolerateErrorKind::NotFoundduring recursive traversal by skipping disappeared entries/directories and continuing listing.FsListerto handle transientNotFoundfromnext_entry,file_type, andmetadatapaths:readdirand metadata probing.NotFounderrors unchanged.Are there any user-facing changes?
No API changes. Runtime behavior becomes more resilient for concurrent list/delete races.
AI Usage Statement
This PR was developed with Codex (GPT-5) assistance, with human review.