Rename the PolarisEvent entity class to EventEntity#4731
Open
adutra wants to merge 1 commit into
Open
Conversation
The `org.apache.polaris.core.entity.PolarisEvent` class has a confusing name since it clashes with `org.apache.polaris.service.events.PolarisEvent` and does not bear the `Entity` suffix that other entity classes sport. This change fixes that.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR resolves a naming collision between the service-layer org.apache.polaris.service.events.PolarisEvent and the core entity currently named org.apache.polaris.core.entity.PolarisEvent by renaming the core entity to EventEntity (aligning with other *Entity types).
Changes:
- Rename the core persistence entity class
PolarisEventtoEventEntity. - Update event persistence/listener plumbing to use
EventEntitythroughout (PolarisPersistenceEventListener, in-memory buffer listener). - Update JDBC model conversion and related tests to use
EventEntity.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| runtime/service/src/test/java/org/apache/polaris/service/events/listeners/PolarisPersistenceEventListenerTest.java | Updates listener tests to assert against EventEntity instead of the old entity name. |
| runtime/service/src/test/java/org/apache/polaris/service/events/listeners/inmemory/InMemoryBufferEventListenerTestBase.java | Updates test helper to construct EventEntity and use its ResourceType. |
| runtime/service/src/test/java/org/apache/polaris/service/events/listeners/inmemory/InMemoryBufferEventListenerIntegrationTest.java | Updates integration assertions and result conversion types to EventEntity. |
| runtime/service/src/main/java/org/apache/polaris/service/events/listeners/PolarisPersistenceEventListener.java | Updates the persisted event object created from service events to EventEntity. |
| runtime/service/src/main/java/org/apache/polaris/service/events/listeners/inmemory/InMemoryBufferEventListener.java | Updates the in-memory buffering/persistence pipeline generics and method signatures to EventEntity. |
| polaris-core/src/main/java/org/apache/polaris/core/persistence/TransactionWorkspaceMetaStoreManager.java | Updates the writeEvents API surface to accept List<EventEntity>. |
| polaris-core/src/main/java/org/apache/polaris/core/persistence/transactional/AbstractTransactionalPersistence.java | Updates the writeEvents signature to List<EventEntity>. |
| polaris-core/src/main/java/org/apache/polaris/core/persistence/BasePersistence.java | Updates the writeEvents SPI signature to List<EventEntity>. |
| polaris-core/src/main/java/org/apache/polaris/core/entity/PolarisEventManager.java | Updates the default writeEvents delegation signature to List<EventEntity>. |
| polaris-core/src/main/java/org/apache/polaris/core/entity/EventEntity.java | Renames the core entity class and constructor to EventEntity. |
| persistence/relational-jdbc/src/test/java/org/apache/polaris/persistence/relational/jdbc/models/ModelEventTest.java | Updates JDBC model conversion tests to use EventEntity. |
| persistence/relational-jdbc/src/test/java/org/apache/polaris/persistence/relational/jdbc/DatasourceOperationsTest.java | Updates JDBC batch write test data to use EventEntity.ResourceType. |
| persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/models/ModelEvent.java | Updates model converter interface and conversion helpers to/from EventEntity. |
| persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcBasePersistenceImpl.java | Updates JDBC persistence implementation to accept List<EventEntity>. |
| persistence/nosql/persistence/metastore/src/main/java/org/apache/polaris/persistence/nosql/metastore/NoSqlMetaStoreManager.java | Updates writeEvents signature to List<EventEntity> (still unsupported for NoSQL). |
| persistence/nosql/persistence/metastore/src/main/java/org/apache/polaris/persistence/nosql/metastore/NonFunctionalBasePersistence.java | Updates writeEvents signature to List<EventEntity>. |
dimas-b
approved these changes
Jun 12, 2026
nandorKollar
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
org.apache.polaris.core.entity.PolarisEventclass has a confusing name since it clashes withorg.apache.polaris.service.events.PolarisEventand does not bear theEntitysuffix that other entity classes sport. This change fixes that.Checklist
CHANGELOG.md(if needed)site/content/in-dev/unreleased(if needed)