Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
import java.util.function.Supplier;
import org.apache.polaris.core.PolarisCallContext;
import org.apache.polaris.core.config.FeatureConfiguration;
import org.apache.polaris.core.entity.EventEntity;
import org.apache.polaris.core.entity.LocationBasedEntity;
import org.apache.polaris.core.entity.PolarisBaseEntity;
import org.apache.polaris.core.entity.PolarisEntity;
Expand All @@ -42,7 +43,6 @@
import org.apache.polaris.core.entity.PolarisEntityId;
import org.apache.polaris.core.entity.PolarisEntitySubType;
import org.apache.polaris.core.entity.PolarisEntityType;
import org.apache.polaris.core.entity.PolarisEvent;
import org.apache.polaris.core.entity.PolarisGrantRecord;
import org.apache.polaris.core.entity.PolarisPrincipalSecrets;
import org.apache.polaris.core.entity.PolarisPrivilege;
Expand Down Expand Up @@ -687,7 +687,7 @@ public boolean requiresEntityReload() {

@Override
public void writeEvents(
@NonNull PolarisCallContext callCtx, @NonNull List<PolarisEvent> polarisEvents) {
@NonNull PolarisCallContext callCtx, @NonNull List<EventEntity> polarisEvents) {
throw new UnsupportedOperationException("Events not supported in NoSQL persistence");
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,13 @@
import java.util.function.Predicate;
import org.apache.polaris.core.PolarisCallContext;
import org.apache.polaris.core.entity.EntityNameLookupRecord;
import org.apache.polaris.core.entity.EventEntity;
import org.apache.polaris.core.entity.PolarisBaseEntity;
import org.apache.polaris.core.entity.PolarisChangeTrackingVersions;
import org.apache.polaris.core.entity.PolarisEntityCore;
import org.apache.polaris.core.entity.PolarisEntityId;
import org.apache.polaris.core.entity.PolarisEntitySubType;
import org.apache.polaris.core.entity.PolarisEntityType;
import org.apache.polaris.core.entity.PolarisEvent;
import org.apache.polaris.core.entity.PolarisGrantRecord;
import org.apache.polaris.core.entity.PolarisPrincipalSecrets;
import org.apache.polaris.core.persistence.BasePersistence;
Expand Down Expand Up @@ -329,7 +329,7 @@ public PolarisPrincipalSecrets storePrincipalSecrets(
}

@Override
public void writeEvents(@NonNull List<PolarisEvent> events) {
public void writeEvents(@NonNull List<EventEntity> events) {
throw unimplemented();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
import org.apache.polaris.core.PolarisCallContext;
import org.apache.polaris.core.PolarisDiagnostics;
import org.apache.polaris.core.entity.EntityNameLookupRecord;
import org.apache.polaris.core.entity.EventEntity;
import org.apache.polaris.core.entity.LocationBasedEntity;
import org.apache.polaris.core.entity.PolarisBaseEntity;
import org.apache.polaris.core.entity.PolarisChangeTrackingVersions;
Expand All @@ -47,7 +48,6 @@
import org.apache.polaris.core.entity.PolarisEntitySubType;
import org.apache.polaris.core.entity.PolarisEntityType;
import org.apache.polaris.core.entity.PolarisEntityUtils;
import org.apache.polaris.core.entity.PolarisEvent;
import org.apache.polaris.core.entity.PolarisGrantRecord;
import org.apache.polaris.core.entity.PolarisPrincipalSecrets;
import org.apache.polaris.core.exceptions.AlreadyExistsException;
Expand Down Expand Up @@ -277,7 +277,7 @@ public void writeToGrantRecords(
}

@Override
public void writeEvents(@NonNull List<PolarisEvent> events) {
public void writeEvents(@NonNull List<EventEntity> events) {
if (events.isEmpty()) {
return; // or throw if empty list is invalid
}
Expand All @@ -301,7 +301,7 @@ public void writeEvents(@NonNull List<PolarisEvent> events) {

// Process remaining events and verify SQL consistency
for (int i = 1; i < events.size(); i++) {
PolarisEvent event = events.get(i);
EventEntity event = events.get(i);
PreparedQuery pq =
QueryGenerator.generateInsertQuery(
ModelEvent.ALL_COLUMNS,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,13 @@
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
import org.apache.polaris.core.entity.PolarisEvent;
import org.apache.polaris.core.entity.EventEntity;
import org.apache.polaris.immutables.PolarisImmutable;
import org.apache.polaris.persistence.relational.jdbc.DatabaseType;
import org.jspecify.annotations.Nullable;

@PolarisImmutable
public interface ModelEvent extends Converter<PolarisEvent> {
public interface ModelEvent extends Converter<EventEntity> {
String TABLE_NAME = "EVENTS";

String CATALOG_ID = "catalog_id";
Expand Down Expand Up @@ -68,7 +68,7 @@ public interface ModelEvent extends Converter<PolarisEvent> {
.eventType("")
.timestampMs(0L)
.principalName("")
.resourceType(PolarisEvent.ResourceType.CATALOG)
.resourceType(EventEntity.ResourceType.CATALOG)
.resourceIdentifier("")
.additionalProperties("")
.build();
Expand All @@ -92,7 +92,7 @@ public interface ModelEvent extends Converter<PolarisEvent> {
@Nullable String getPrincipalName();

// Enum that states the type of resource was being operated on
PolarisEvent.ResourceType getResourceType();
EventEntity.ResourceType getResourceType();

// Which resource was operated on
String getResourceIdentifier();
Expand All @@ -101,7 +101,7 @@ public interface ModelEvent extends Converter<PolarisEvent> {
String getAdditionalProperties();

@Override
default PolarisEvent fromResultSet(ResultSet rs) throws SQLException {
default EventEntity fromResultSet(ResultSet rs) throws SQLException {
var modelEvent =
ImmutableModelEvent.builder()
.catalogId(rs.getString(CATALOG_ID))
Expand All @@ -110,7 +110,7 @@ default PolarisEvent fromResultSet(ResultSet rs) throws SQLException {
.eventType(rs.getString(EVENT_TYPE))
.timestampMs(rs.getLong(TIMESTAMP_MS))
.principalName(rs.getString(PRINCIPAL_NAME))
.resourceType(PolarisEvent.ResourceType.valueOf(rs.getString(RESOURCE_TYPE)))
.resourceType(EventEntity.ResourceType.valueOf(rs.getString(RESOURCE_TYPE)))
.resourceIdentifier(rs.getString(RESOURCE_IDENTIFIER))
.additionalProperties(rs.getString(ADDITIONAL_PROPERTIES))
.build();
Expand All @@ -136,7 +136,7 @@ default Map<String, Object> toMap(DatabaseType databaseType) {
return map;
}

static ModelEvent fromEvent(PolarisEvent event) {
static ModelEvent fromEvent(EventEntity event) {
if (event == null) return null;

return ImmutableModelEvent.builder()
Expand All @@ -152,11 +152,11 @@ static ModelEvent fromEvent(PolarisEvent event) {
.build();
}

static PolarisEvent toEvent(ModelEvent model) {
static EventEntity toEvent(ModelEvent model) {
if (model == null) return null;

PolarisEvent polarisEvent =
new PolarisEvent(
EventEntity polarisEvent =
new EventEntity(
model.getCatalogId(),
model.getEventId(),
model.getRequestId(),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
import java.util.List;
import java.util.Optional;
import javax.sql.DataSource;
import org.apache.polaris.core.entity.PolarisEvent;
import org.apache.polaris.core.entity.EventEntity;
import org.apache.polaris.persistence.relational.jdbc.DatasourceOperations.Operation;
import org.apache.polaris.persistence.relational.jdbc.models.ImmutableModelEvent;
import org.apache.polaris.persistence.relational.jdbc.models.ModelEntity;
Expand Down Expand Up @@ -108,7 +108,7 @@ void executeBatchUpdate_success() throws Exception {
for (int i = 0; i < 1000; i++) {
ModelEvent modelEvent =
ImmutableModelEvent.builder()
.resourceType(PolarisEvent.ResourceType.CATALOG)
.resourceType(EventEntity.ResourceType.CATALOG)
.resourceIdentifier("catalog_" + i)
.catalogId("catalog_" + i)
.eventId("event_" + i)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
import java.sql.ResultSet;
import java.sql.SQLException;
import java.util.Map;
import org.apache.polaris.core.entity.PolarisEvent;
import org.apache.polaris.core.entity.EventEntity;
import org.apache.polaris.persistence.relational.jdbc.DatabaseType;
import org.junit.jupiter.api.Test;
import org.postgresql.util.PGobject;
Expand All @@ -49,8 +49,7 @@ public class ModelEventTest {
private static final String TEST_EVENT_TYPE = "CREATE";
private static final long TEST_TIMESTAMP_MS = 1234567890L;
private static final String TEST_USER = "test-user";
private static final PolarisEvent.ResourceType TEST_RESOURCE_TYPE =
PolarisEvent.ResourceType.TABLE;
private static final EventEntity.ResourceType TEST_RESOURCE_TYPE = EventEntity.ResourceType.TABLE;
private static final String TEST_RESOURCE_TYPE_STRING = "TABLE";
private static final String TEST_RESOURCE_IDENTIFIER = "test-table";
private static final String EMPTY_JSON = "{}";
Expand All @@ -71,7 +70,7 @@ public void testFromResultSet() throws SQLException {
when(mockResultSet.getString(ADDITIONAL_PROPERTIES)).thenReturn(EMPTY_JSON);

// Act
PolarisEvent result = ModelEvent.CONVERTER.fromResultSet(mockResultSet);
EventEntity result = ModelEvent.CONVERTER.fromResultSet(mockResultSet);

// Assert
assertEquals(TEST_CATALOG_ID, result.getCatalogId());
Expand Down Expand Up @@ -163,8 +162,8 @@ public void testFromEventWithNullInput() {
@Test
public void testFromEvent() {
// Arrange
PolarisEvent polarisEvent =
new PolarisEvent(
EventEntity polarisEvent =
new EventEntity(
TEST_CATALOG_ID,
TEST_EVENT_ID,
TEST_REQUEST_ID,
Expand Down Expand Up @@ -207,7 +206,7 @@ public void testToEvent() {
.build();

// Act
PolarisEvent result = ModelEvent.toEvent(modelEvent);
EventEntity result = ModelEvent.toEvent(modelEvent);

// Assert
assertEquals(TEST_CATALOG_ID, result.getCatalogId());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
import java.util.Map;
import org.jspecify.annotations.Nullable;

public class PolarisEvent {
public class EventEntity {
public static final String EMPTY_MAP_STRING = "{}";

/**
Expand Down Expand Up @@ -118,7 +118,7 @@ public String getAdditionalProperties() {
return additionalProperties != null ? additionalProperties : EMPTY_MAP_STRING;
}

public PolarisEvent(
public EventEntity(
String catalogId,
String id,
@Nullable String requestId,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@

public interface PolarisEventManager {
default void writeEvents(
@NonNull PolarisCallContext callCtx, @NonNull List<PolarisEvent> polarisEvents) {
@NonNull PolarisCallContext callCtx, @NonNull List<EventEntity> polarisEvents) {
BasePersistence ms = callCtx.getMetaStore();
ms.writeEvents(polarisEvents);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import java.util.function.Predicate;
import org.apache.polaris.core.PolarisCallContext;
import org.apache.polaris.core.entity.EntityNameLookupRecord;
import org.apache.polaris.core.entity.EventEntity;
import org.apache.polaris.core.entity.LocationBasedEntity;
import org.apache.polaris.core.entity.PolarisBaseEntity;
import org.apache.polaris.core.entity.PolarisChangeTrackingVersions;
Expand All @@ -32,7 +33,6 @@
import org.apache.polaris.core.entity.PolarisEntityId;
import org.apache.polaris.core.entity.PolarisEntitySubType;
import org.apache.polaris.core.entity.PolarisEntityType;
import org.apache.polaris.core.entity.PolarisEvent;
import org.apache.polaris.core.entity.PolarisGrantRecord;
import org.apache.polaris.core.persistence.pagination.Page;
import org.apache.polaris.core.persistence.pagination.PageToken;
Expand Down Expand Up @@ -148,7 +148,7 @@ void writeToGrantRecords(
*
* @param events events to persist
*/
void writeEvents(@NonNull List<PolarisEvent> events);
void writeEvents(@NonNull List<EventEntity> events);

/**
* Delete this entity from the meta store.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,14 @@
import java.util.Optional;
import org.apache.polaris.core.PolarisCallContext;
import org.apache.polaris.core.PolarisDiagnostics;
import org.apache.polaris.core.entity.EventEntity;
import org.apache.polaris.core.entity.LocationBasedEntity;
import org.apache.polaris.core.entity.PolarisBaseEntity;
import org.apache.polaris.core.entity.PolarisEntity;
import org.apache.polaris.core.entity.PolarisEntityCore;
import org.apache.polaris.core.entity.PolarisEntityId;
import org.apache.polaris.core.entity.PolarisEntitySubType;
import org.apache.polaris.core.entity.PolarisEntityType;
import org.apache.polaris.core.entity.PolarisEvent;
import org.apache.polaris.core.entity.PolarisPrivilege;
import org.apache.polaris.core.entity.PrincipalEntity;
import org.apache.polaris.core.persistence.dao.entity.BaseResult;
Expand Down Expand Up @@ -396,7 +396,7 @@ Optional<Optional<String>> hasOverlappingSiblings(

@Override
public void writeEvents(
@NonNull PolarisCallContext callCtx, @NonNull List<PolarisEvent> polarisEvents) {
@NonNull PolarisCallContext callCtx, @NonNull List<EventEntity> polarisEvents) {
throw illegalMethodError("writeEvents");
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,14 @@
import org.apache.polaris.core.PolarisCallContext;
import org.apache.polaris.core.PolarisDiagnostics;
import org.apache.polaris.core.entity.EntityNameLookupRecord;
import org.apache.polaris.core.entity.EventEntity;
import org.apache.polaris.core.entity.PolarisBaseEntity;
import org.apache.polaris.core.entity.PolarisChangeTrackingVersions;
import org.apache.polaris.core.entity.PolarisEntitiesActiveKey;
import org.apache.polaris.core.entity.PolarisEntityCore;
import org.apache.polaris.core.entity.PolarisEntityId;
import org.apache.polaris.core.entity.PolarisEntitySubType;
import org.apache.polaris.core.entity.PolarisEntityType;
import org.apache.polaris.core.entity.PolarisEvent;
import org.apache.polaris.core.entity.PolarisGrantRecord;
import org.apache.polaris.core.entity.PolarisPrincipalSecrets;
import org.apache.polaris.core.persistence.EntityAlreadyExistsException;
Expand Down Expand Up @@ -275,7 +275,7 @@ public void writeToGrantRecords(
}

@Override
public void writeEvents(@NonNull List<PolarisEvent> events) {
public void writeEvents(@NonNull List<EventEntity> events) {
throw new UnsupportedOperationException("Not implemented for transactional persistence.");
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@
import org.apache.iceberg.rest.requests.RenameTableRequest;
import org.apache.iceberg.rest.responses.LoadTableResponse;
import org.apache.polaris.core.auth.PolarisPrincipal;
import org.apache.polaris.core.entity.PolarisEvent.ResourceType;
import org.apache.polaris.core.entity.EventEntity;
import org.apache.polaris.core.entity.EventEntity.ResourceType;
import org.apache.polaris.service.events.AttributeKey;
import org.apache.polaris.service.events.EventAttributeMap;
import org.apache.polaris.service.events.EventAttributes;
Expand All @@ -47,8 +48,8 @@ public void onEvent(PolarisEvent event) {
ResourceType resourceType = resolveResourceType(event.type());
String resourceIdentifier = resolveResourceIdentifier(event, resourceType, catalogName);

org.apache.polaris.core.entity.PolarisEvent polarisEvent =
new org.apache.polaris.core.entity.PolarisEvent(
EventEntity polarisEvent =
new EventEntity(
catalogName,
event.metadata().eventId().toString(),
event.metadata().requestId().orElse(null),
Expand All @@ -67,10 +68,7 @@ public void onEvent(PolarisEvent event) {
}

private static String resolveCatalogName(PolarisEvent event) {
return event
.attributes()
.get(EventAttributes.CATALOG_NAME)
.orElse(org.apache.polaris.core.entity.PolarisEvent.REALM_SCOPED);
return event.attributes().get(EventAttributes.CATALOG_NAME).orElse(EventEntity.REALM_SCOPED);
}

/**
Expand Down Expand Up @@ -236,7 +234,7 @@ private static String resolveRealmResourceIdentifier(PolarisEvent event) {
}

private static String fallbackResourceIdentifier(PolarisEvent event, String catalogName) {
if (!org.apache.polaris.core.entity.PolarisEvent.REALM_SCOPED.equals(catalogName)) {
if (!EventEntity.REALM_SCOPED.equals(catalogName)) {
return catalogName;
}
return event.type().name();
Expand Down Expand Up @@ -307,6 +305,5 @@ private static Map<String, String> pruneTableMetadata(TableMetadata metadata) {
return summary;
}

protected abstract void processEvent(
String realmId, org.apache.polaris.core.entity.PolarisEvent event);
protected abstract void processEvent(String realmId, EventEntity event);
}
Loading