[Hotfix][Connector-V2][Jdbc] Flink engine, source is LocalFile, sink … #6990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you investigate why the LocalFile is behaving in such a peculiar manner? |
Hisoka-X
reviewed
Jun 20, 2024
| @@ -92,6 +92,7 @@ public MultiTableResourceManager<ConnectionPoolManager> initMultiTableResourceMa | |||
| ds.setPassword(jdbcSinkConfig.getJdbcConnectionConfig().getPassword().get()); | |||
| } | |||
| ds.setAutoCommit(jdbcSinkConfig.getJdbcConnectionConfig().isAutoCommit()); | |||
| ds.setDriverClassName(jdbcSinkConfig.getJdbcConnectionConfig().getDriverName()); | |||
There was a problem hiding this comment.
Do we really need this part? Because flink e2e work fine without this change. (E2E use same logic to submit job)
There was a problem hiding this comment.
When I debug into DriverDataSource init，if the driverClassName is not null it worked fine. Please look the issues (#6902)
There was a problem hiding this comment.
Do you use flink with standalone mode?
There was a problem hiding this comment.
Yes, the version is 1.16.1
There was a problem hiding this comment.
If you use flink standalone mode, I suggest putting the driver under flink/libs, otherwise flink may have the risk of memory leaks.
github-actions
bot
added
document
core
…is jdbc, get "No suitable driver" Exception fix (apache#6902)
github-actions
bot
added
connectors-v2
jdbc
and removed
core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…is jdbc, get "No suitable driver" Exception fix (#6902)
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.