Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix][Connector-V2][Jdbc] Flink engine, source is LocalFile, sink … #6990

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
+1 −0
Open

[Hotfix][Connector-V2][Jdbc] Flink engine, source is LocalFile, sink … #6990

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...dbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/sink/JdbcSinkWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ public MultiTableResourceManager<ConnectionPoolManager> initMultiTableResourceMa
ds.setPassword(jdbcSinkConfig.getJdbcConnectionConfig().getPassword().get());
}
ds.setAutoCommit(jdbcSinkConfig.getJdbcConnectionConfig().isAutoCommit());
ds.setDriverClassName(jdbcSinkConfig.getJdbcConnectionConfig().getDriverName());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need this part? Because flink e2e work fine without this change. (E2E use same logic to submit job)

Copy link
Author

@luoyongsir luoyongsir Jun 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

微信图片_20240621171135
微信图片_20240621171149

When I debug into DriverDataSource init，if the driverClassName is not null it worked fine. Please look the issues (#6902)

Copy link
Member

@Hisoka-X Hisoka-X Jun 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you use flink with standalone mode?

Copy link
Author

@luoyongsir luoyongsir Jun 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the version is 1.16.1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you use flink standalone mode, I suggest putting the driver under flink/libs, otherwise flink may have the risk of memory leaks.

return new JdbcMultiTableResourceManager(new ConnectionPoolManager(ds));
}

Expand Down
Loading