feat(theming): land Ant Design v5 overhaul — dynamic themes, real dark mode + massive styling refactor #31590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment
|
mistercrunch
force-pushed
the
template_less
branch
2 times, most recently
from
f1c7929 to
43452ff
Compare
mistercrunch
force-pushed
the
template_less
branch
from
97e182d to
0655910
Compare
mistercrunch
changed the title
mistercrunch
changed the title
mistercrunch
force-pushed
the
template_less
branch
from
1ca8e6e to
6c6532e
Compare
github-actions
bot
added
the
github_actions
mistercrunch
force-pushed
the
template_less
branch
2 times, most recently
from
003f992 to
1652452
Compare
mistercrunch
added a commit
that referenced
this pull request
Jan 14, 2025
Chiseling at #31590 and bringing what's atomically committable out of there. This simply adds eslint checks to pre-commit. Note that: - it requires having run `npm i` in superset-frontend - it's set up to NOT run in CI as part of the pre-commit validation workflow, since we run eslint more formally in another workflow Why doing this? Currently it's common to forget to run `npm run lint` prior to committing/pushing, so people can waste time waiting for CI to fail where it could be caught easily. It's nice to have pre-commit do the check itself because it will only evaluate the files that have changed, making it much faster than running a full lint run against all files.
mistercrunch
added a commit
that referenced
this pull request
Jan 14, 2025
…rt/e2e.ts While working on #31590, I noticed that `expect` was not properly imported. It was using it from global for some unknown reason.
mistercrunch
force-pushed
the
template_less
branch
from
1652452 to
f89a23b
Compare
github-actions
bot
removed
the
github_actions
mistercrunch
added a commit
that referenced
this pull request
Jan 15, 2025
Chiseling at #31590 that has gotten big / unruly, in this PR is a refactor of Alert-related components, going vanilla AntD. Also. Deprecating colors.alerts since it's ambiguous/redundant with warning/error and does not exist in antd-v5
mistercrunch
added a commit
that referenced
this pull request
Jan 16, 2025
Chiseling at #31590 that has gotten big / unruly, in this PR is a refactor of Alert-related components, going vanilla AntD. Also. Deprecating colors.alerts since it's ambiguous/redundant with warning/error and does not exist in antd-v5
mistercrunch
added a commit
that referenced
this pull request
Jan 16, 2025
Chiseling at #31590 that has gotten big / unruly, in this PR is a refactor of Alert-related components, going vanilla AntD. Also. Deprecating colors.alerts since it's ambiguous/redundant with warning/error and does not exist in antd-v5
mistercrunch
added a commit
that referenced
this pull request
Jan 18, 2025
Chiseling at #31590 that has gotten big / unruly, in this PR is a refactor of Alert-related components, going vanilla AntD. Also. Deprecating colors.alerts since it's ambiguous/redundant with warning/error and does not exist in antd-v5
mistercrunch
added a commit
that referenced
this pull request
Jan 18, 2025
Chiseling at #31590 that has gotten big / unruly, in this PR is a refactor of Alert-related components, going vanilla AntD. Also. Deprecating colors.alerts since it's ambiguous/redundant with warning/error and does not exist in antd-v5
geido
approved these changes
Jun 19, 2025
EnxDev
approved these changes
Jun 19, 2025
rusackas
approved these changes
Jun 20, 2025
mistercrunch
changed the title
|
|
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges the long-running “theming” branch into
master.Superset is now fully, dynamically themeable. We’ve moved to Ant Design v5’s
token-based theming and css-in-js, killed the last traces of Bootstrap/.less,
and unlocked a first-class dark mode.
Highlights
@superset-ui/core/componentsfor easy reusesuperset_config.py); WYSIWYG editor behind a FFBy the numbers
masterthe whole wayKnown gaps / follow-ups
theme.colors.*tokensBREAKING CHANGES
THEME_OVERRIDESis gone — configs must move to the new Antd-compatible JSONHuge thanks to everyone who battled merge conflicts and kept this branch alive.
Ready for prime time — let’s ship it. 🚀