fix(theming): Fix visual regressions from theming P6#33898
Merged
Conversation
EnxDev
added
change:frontend
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've completed my review and didn't find any issues.
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/packages/superset-ui-core/src/components/FaveStar/index.tsx | ✅ |
| superset-frontend/src/explore/components/controls/TextAreaControl.jsx | ✅ |
| superset-frontend/packages/superset-ui-core/src/components/MetadataBar/MetadataBar.tsx | ✅ |
| superset-frontend/src/dashboard/components/Header/index.jsx | ✅ |
| superset-frontend/src/pages/DatasetList/index.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
EnxDev
requested review from
betodealmeida,
eschutho,
rusackas and
sadpandajoe
as code owners
LisaHusband
pushed a commit
to LisaHusband/superset
that referenced
this pull request
Jun 28, 2025
ianngech
pushed a commit
to Pesapal-Ltd/superset
that referenced
this pull request
Jul 3, 2025
# Conflicts: # superset-frontend/cypress-base/cypress/e2e/dashboard/actions.test.js # superset-frontend/src/components/FaveStar/index.tsx # superset-frontend/src/components/MetadataBar/MetadataBar.test.tsx # superset-frontend/src/components/MetadataBar/MetadataBar.tsx # superset-frontend/src/explore/components/controls/TextAreaControl.jsx
github-actions
bot
added
🏷️ bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
This pull request introduces minor UI refinements aimed at fixing visual inconsistencies that emerged after the recent theming changes (#31590)
The primary goal is to restore visual coherence and ensure components align with the intended design system.
No logic or functional behavior has been modified.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
After
Before
After
Before
After
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION