Skip to content

TIKA-4545-jsonify-all-the-things - #2418

Merged
tballison merged 1 commit into
mainfrom
TIKA-4545-jsonify-all-the-things
Dec 3, 2025
Merged

TIKA-4545-jsonify-all-the-things#2418
tballison merged 1 commit into
mainfrom
TIKA-4545-jsonify-all-the-things

Conversation

@tballison

Copy link
Copy Markdown
Contributor

Thanks for your contribution to Apache Tika! Your help is appreciated!

Before opening the pull request, please verify that

  • there is an open issue on the Tika issue tracker which describes the problem or the improvement. We cannot accept pull requests without an issue because the change wouldn't be listed in the release notes.
  • the issue ID (TIKA-XXXX)
    • is referenced in the title of the pull request
    • and placed in front of your commit messages surrounded by square brackets ([TIKA-XXXX] Issue or pull request title)
  • commits are squashed into a single one (or few commits for larger changes)
  • Tika is successfully built and unit tests pass by running mvn clean test
  • there should be no conflicts when merging the pull request branch into the recent main branch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulled main branch
  • if you add new module that downstream users will depend upon add it to relevant group in tika-bom/pom.xml.

We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Tika in general, please sign up for the Tika mailing list. Thanks!

@tballison
tballison marked this pull request as ready for review December 2, 2025 22:50
@tballison
tballison marked this pull request as draft December 2, 2025 22:52
@tballison

Copy link
Copy Markdown
Contributor Author

Still working on this one. Once it is ready, this should be merged after #2417.

There's still quite a bit to be done here.

This integrates the json configs across the parsers, detectors, etc and the pipes/plugin components.

@tballison

Copy link
Copy Markdown
Contributor Author

I had to set this export DOCKER_API_VERSION=1.44 for the s3 integration tests, but I was able to get a clean build locally with checkstyle turned off.

I'll fix checkstyle stuff tomorrow and then review thoroughly.

@nddipiazza I left grpc in not a great state, but I pass the baton to you once this is merged.

@tballison
tballison force-pushed the TIKA-4545-jsonify-all-the-things branch from 4b12234 to 9568599 Compare December 3, 2025 13:57
@tballison
tballison marked this pull request as ready for review December 3, 2025 13:59
…uration throughout

Generated-by: Claude Sonnet 4.5 (claude-sonnet-4-5-20250929)
Significant design and implementation on ConfigLoader with Claude
@tballison
tballison force-pushed the TIKA-4545-jsonify-all-the-things branch from c068b31 to c063c8f Compare December 3, 2025 17:03
@tballison
tballison merged commit 0f7cad3 into main Dec 3, 2025
4 checks passed
@tballison
tballison deleted the TIKA-4545-jsonify-all-the-things branch December 3, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant